summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew McRae <amcrae@google.com>2019-12-20 05:51:41 +1100
committerCommit Bot <commit-bot@chromium.org>2019-12-20 01:37:29 +0000
commitd34e19b1c8a7bee59c3c1564b22a35f6289e402f (patch)
tree41f11d3ef29c67082f84ed09f8ed5b09eab33fb6
parentd4e9357a4923a43a92d04433fcdd04caf797ea49 (diff)
downloadchrome-ec-d34e19b1c8a7bee59c3c1564b22a35f6289e402f.tar.gz
puff: Fix LED display.
Make sure LED power and alert/critical states turn on the LEDs. BRANCH=none BUG=b:146523469 TEST=Verify on puff Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Ic20e366f60b2a32ffeef270a3a1aaee6a05ed031 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1977065 Tested-by: Andrew McRae <amcrae@chromium.org> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Commit-Queue: Andrew McRae <amcrae@chromium.org>
-rw-r--r--board/puff/led.c13
1 files changed, 7 insertions, 6 deletions
diff --git a/board/puff/led.c b/board/puff/led.c
index 1b814e8aa0..49dfbce935 100644
--- a/board/puff/led.c
+++ b/board/puff/led.c
@@ -122,13 +122,7 @@ static void led_tick(void)
uint32_t elapsed;
uint32_t next = 0;
uint32_t start = get_time().le.lo;
- static uint8_t pwm_enabled = 0;
- if (!pwm_enabled) {
- pwm_enable(PWM_CH_LED_RED, 1);
- pwm_enable(PWM_CH_LED_GREEN, 1);
- pwm_enabled = 1;
- }
if (led_auto_control_is_enabled(EC_LED_ID_POWER_LED))
pulse_power_led(led_pulse.color);
elapsed = get_time().le.lo - start;
@@ -161,6 +155,13 @@ static void led_resume(void)
}
DECLARE_HOOK(HOOK_CHIPSET_RESUME, led_resume, HOOK_PRIO_DEFAULT);
+static void led_init(void)
+{
+ pwm_enable(PWM_CH_LED_RED, 1);
+ pwm_enable(PWM_CH_LED_GREEN, 1);
+}
+DECLARE_HOOK(HOOK_INIT, led_init, HOOK_PRIO_INIT_PWM + 1);
+
void led_alert(int enable)
{
if (enable) {