diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2016-01-11 09:43:28 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-01-11 14:05:01 -0800 |
| commit | 726ce9700286c390d86d23ed306dd2a9b4c60adf (patch) | |
| tree | 4975bea88522557d156a7ad73c9b4ec419563c16 | |
| parent | 3d5c5e81866646998a04fb2423ad3766d242dc1a (diff) | |
| download | chrome-ec-726ce9700286c390d86d23ed306dd2a9b4c60adf.tar.gz | |
util: presubmit_check.sh: Fix (again) for ec3po.
If a user had already run util/ec3po/run_tests.sh, and then never
modified any ec3po files, the presubmit check would list every file in
the EC repo that was newer since the the last run. This included
files such as build artifacts.
BUG=chromium:575032
BRANCH=None
TEST=Run ./util/ec3po/run_tests.sh once. Run make -j buildall, try to
upload and verify that no nag message to run ec3po tests is presented.
TEST=Touch an ec3po file, try to upload, verify that nag message about
running ec3po unit tests is presented.
Change-Id: I4f09bb76dcd85b570b57030197f4887bed85f1a7
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/321134
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
| -rwxr-xr-x | util/presubmit_check.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/presubmit_check.sh b/util/presubmit_check.sh index a0b1488ccd..0ba4776473 100755 --- a/util/presubmit_check.sh +++ b/util/presubmit_check.sh @@ -26,7 +26,7 @@ if [[ ! -e util/ec3po/.tests-passed ]] && [[ -n "${ec3po_files}" ]]; then fi changed_ec3po_files=$(find ${ec3po_files} -newer util/ec3po/.tests-passed) -if [[ -n ${changed_ec3po_files} ]]; then +if [[ -n "${changed_ec3po_files}" ]] && [[ -n "${ec3po_files}" ]]; then echo "Files have changed since last time EC-3PO unit tests passed:" echo "${changed_ec3po_files}" | sed -e 's/^/ /' echo 'Please run "util/ec3po/run_tests.sh".' |