diff options
| author | Shawn Nematbakhsh <shawnn@chromium.org> | 2016-07-25 13:20:56 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-07-25 17:09:04 -0700 |
| commit | d4b6f8153ddd6a2ecfbe6fcf189c6300e767bdb0 (patch) | |
| tree | 93e112af89093850fa70ce4d4c7e0677fae77b5e | |
| parent | 7369f0a68912dbd749271b79606c569071db0a13 (diff) | |
| download | chrome-ec-d4b6f8153ddd6a2ecfbe6fcf189c6300e767bdb0.tar.gz | |
charger: bd99955: Remove incorrect VSYSVAL_THL / THH settings
VSYSVAL_THL / THH are high / low hysteresis values below which dead
battery condition is triggered, which doesn't match our register
configuration. Leave these regs at default for now until we better
understand the effect of dead battery detection.
BUG=chrome-os-partner:55626
BRANCH=None
TEST=Manual on kevin with other pending changes, verify dead battery
successfully charges.
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: I35a44dd0005f165f17073e8b0f2fd5dca1eda856
Reviewed-on: https://chromium-review.googlesource.com/363030
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
| -rw-r--r-- | driver/charger/bd99955.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/driver/charger/bd99955.c b/driver/charger/bd99955.c index 260eba8945..3f8e54ce65 100644 --- a/driver/charger/bd99955.c +++ b/driver/charger/bd99955.c @@ -789,13 +789,7 @@ static void bd99995_init(void) ch_raw_write16(BD99955_CMD_CHGOP_SET2, reg, BD99955_EXTENDED_COMMAND); - /* VSYS Valid Threshold High & Low Settings */ - ch_raw_write16(BD99955_CMD_VSYSVAL_THH_SET, - bi->voltage_max & 0x7fe0, - BD99955_EXTENDED_COMMAND); - ch_raw_write16(BD99955_CMD_VSYSVAL_THL_SET, - bi->voltage_min & 0x7fe0, - BD99955_EXTENDED_COMMAND); + /* TODO(crosbug.com/p/55626): Set VSYSVAL_THH/THL appropriately */ /* Set battery OVP to 500 + maximum battery voltage */ ch_raw_write16(BD99955_CMD_VBATOVP_SET, |