summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@chromium.org>2013-06-13 15:13:00 -0700
committerChromeBot <chrome-bot@google.com>2013-06-13 18:13:20 -0700
commitf2fa913320c274661e969a49e4dac65622971851 (patch)
tree0a42bf780ca7634897804d26b554be2c1966d750
parent61ae739eef0af9aa24d15dd9d0de42456f1e6420 (diff)
downloadchrome-ec-f2fa913320c274661e969a49e4dac65622971851.tar.gz
falco: fix RCIN# GPIO setting
The gpio pin used for RCIN# should be configured as open drain as the rail is pulled up by a non-EC rail. Driving it high would leak power. BUG=chrome-os-partner:19355,chrome-os-partner:20173 BRANCH=none TEST=manual: boot on falco without RCIN# causing reset and the 'apreset warm' EC command works as expected. Change-Id: I197928fd3cac27db3add9dd842e3171f23c9d71e Signed-off-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/58590
-rw-r--r--board/falco/board.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/board/falco/board.c b/board/falco/board.c
index 828e7965a7..95c47f3d80 100644
--- a/board/falco/board.c
+++ b/board/falco/board.c
@@ -98,7 +98,7 @@ const struct gpio_info gpio_list[GPIO_COUNT] = {
{"PCH_NMI_L", LM4_GPIO_F, (1<<2), GPIO_OUT_HIGH, NULL},
{"PCH_PWRBTN_L", LM4_GPIO_H, (1<<0), GPIO_OUT_HIGH, NULL},
{"PCH_PWROK", LM4_GPIO_F, (1<<5), GPIO_OUT_LOW, NULL},
- {"PCH_RCIN_L", LM4_GPIO_L, (1<<6), GPIO_OUT_HIGH, NULL},
+ {"PCH_RCIN_L", LM4_GPIO_L, (1<<6), GPIO_HI_Z_OPEN, NULL},
{"PCH_RSMRST_L", LM4_GPIO_F, (1<<1), GPIO_OUT_LOW, NULL},
{"PCH_SMI_L", LM4_GPIO_F, (1<<4), GPIO_OUT_HIGH, NULL},
{"TOUCHSCREEN_RESET_L", LM4_GPIO_N, (1<<7), GPIO_OUT_LOW, NULL},