diff options
| author | Abe Levkoy <alevkoy@chromium.org> | 2020-06-29 17:12:03 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-06-30 08:00:52 +0000 |
| commit | 3c7673c5955ece8a1b686fcad177d30442dccaba (patch) | |
| tree | dcce569da89077b7f5aa0bdb09d4bca62874dfba | |
| parent | b6b8b804a8f8146f1d124fc0b903299ad36f1c94 (diff) | |
| download | chrome-ec-3c7673c5955ece8a1b686fcad177d30442dccaba.tar.gz | |
TCPMv2: Set SOP' protocol revision correctly
When setting the protocol revision for SOP' after receiving an SOP'
Discover Identity ACK, use the revision from the received ACK, not the
VDO version code from the PD revision we were already using.
BUG=b:160187091
TEST=Attach PD 3.0 cable; observe 3.0 SOP' traffic
TEST=Attach PE 2.0 cable; observe 2.0 SOP' traffic
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I622ba2a71ae98e6d9c18f3813ac6096781bd1096
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2274641
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
Tested-by: Diana Z <dzigterman@chromium.org>
| -rw-r--r-- | common/usbc/usb_pe_drp_sm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/usbc/usb_pe_drp_sm.c b/common/usbc/usb_pe_drp_sm.c index 356a688e6e..533a6c1f8b 100644 --- a/common/usbc/usb_pe_drp_sm.c +++ b/common/usbc/usb_pe_drp_sm.c @@ -4372,7 +4372,7 @@ static void pe_vdm_identity_request_cbl_run(int port) */ if (prl_get_rev(port, TCPC_TX_SOP) != PD_REV20) prl_set_rev(port, sop, - pd_get_vdo_ver(port, TCPC_TX_SOP_PRIME)); + PD_HEADER_REV(rx_emsg[port].header)); } else if (response_result == PD_DISC_FAIL) { /* * PE_INIT_PORT_VDM_IDENTITY_NAKed and PE_SRC_VDM_Identity_NAKed |