diff options
| author | Sheng-Liang Song <ssl@chromium.org> | 2014-12-17 10:41:52 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-12-18 08:35:58 +0000 |
| commit | 005fa5fea19f406a76eeed50084ae86d38c8de85 (patch) | |
| tree | b4e695f0e44ba470b109242060d7c0b6c29d1c67 | |
| parent | 2d25b40b758445fa29fa003534817acc1244e132 (diff) | |
| download | chrome-ec-005fa5fea19f406a76eeed50084ae86d38c8de85.tar.gz | |
stm32: fixed spi shared_mem_release bug
If shared_mem_acquire() failed, we should not call shared_mem_release().
BRANCH=none
BUG=chrome-os-partner:34703
TEST="Compiled"
Change-Id: I5179f8b75b13451a63eb3209c9156066231aa12d
Signed-off-by: Sheng-Liang Song <ssl@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/236392
Reviewed-by: David Hendricks <dhendrix@chromium.org>
Reviewed-by: Alexandru Stan <amstan@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
| -rw-r--r-- | chip/stm32/spi_master.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chip/stm32/spi_master.c b/chip/stm32/spi_master.c index aa37f191d5..ab95ca6594 100644 --- a/chip/stm32/spi_master.c +++ b/chip/stm32/spi_master.c @@ -166,7 +166,7 @@ int spi_transaction_async(const uint8_t *txdata, int txlen, rv = shared_mem_acquire(MAX(txlen, rxlen), &buf); if (rv != EC_SUCCESS) - goto err_free; + return rv; /* Drive SS low */ gpio_set_level(CONFIG_SPI_CS_GPIO, 0); |