diff options
| author | Hyungwoo Yang <hyungwoo.yang@intel.com> | 2019-05-14 09:31:48 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2019-05-16 15:18:19 +0000 |
| commit | ad799a0b31b7fefdbd83d180b7562e2d0efb2656 (patch) | |
| tree | 777791f3a765f04a8b5391722e610e50ab47d362 | |
| parent | a4e9f83a5b9479574bdb06ea655c0e63c8afee74 (diff) | |
| download | chrome-ec-ad799a0b31b7fefdbd83d180b7562e2d0efb2656.tar.gz | |
ish: fix GPIO interrupt enabling and status
currently the GPIO interrupt mask register and status register are
not initialized on warm reset. so some interrupts can be enabled
even before corresponding things are ready.
this patch disables all GPIO interrupts and clears pending interrupts
during gpio initialization(gpio_pre_init()).
BRANCH=ish
BUG=b:130717887
TEST=tested on Arcada platform
Change-Id: I01c237f667c7a3b6d1eb63d81c9ab604a6213453
Reviewed-on: https://chromium-review.googlesource.com/1611749
Commit-Ready: Jett Rink <jettrink@chromium.org>
Tested-by: Hyungwoo Yang <hyungwoo.yang@intel.com>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1615487
Commit-Queue: Jett Rink <jettrink@chromium.org>
Tested-by: Jett Rink <jettrink@chromium.org>
| -rw-r--r-- | chip/ish/gpio.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/chip/ish/gpio.c b/chip/ish/gpio.c index 7d0a34f18f..18890c111d 100644 --- a/chip/ish/gpio.c +++ b/chip/ish/gpio.c @@ -139,6 +139,11 @@ void gpio_pre_init(void) gpio_set_flags_by_mask(g->port, g->mask, flags); } + + /* disable GPIO interrupts */ + ISH_GPIO_GIMR = 0; + /* clear pending GPIO interrupts */ + ISH_GPIO_GISR = 0xFFFFFFFF; } static void gpio_init(void) |