diff options
| author | Mary Ruthven <mruthven@chromium.org> | 2022-11-07 10:39:29 -0600 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-11-07 18:17:56 +0000 |
| commit | d478eab2eb082728040be64fe1394527a83b117d (patch) | |
| tree | 698a07c07fc52c75e6d6956d1c373a6053acdb8a | |
| parent | 759c6602592e2433d296d4fe65698e30e55857e0 (diff) | |
| download | chrome-ec-d478eab2eb082728040be64fe1394527a83b117d.tar.gz | |
cr50: enable key combo0 on all boards
Key combo0 needs to be enabled on all boards, so it can be used to
release the device from reset after AP RO verification fails.
BUG=b:236844541
TEST=pwrb + refresh releases ec rst after AP RO verification failed on
hatch
Change-Id: If5d434a32aba09fd4af85cd668d34997d5851216
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4009402
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
| -rw-r--r-- | board/cr50/board.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/board/cr50/board.c b/board/cr50/board.c index 30800b1e46..7fa4ced4c5 100644 --- a/board/cr50/board.c +++ b/board/cr50/board.c @@ -1014,14 +1014,11 @@ static void board_init(void) /* * Enable interrupt handler for RBOX key combo so it can be used to - * store the recovery request and reset ec_efs. + * store the recovery request, reset ec_efs, and clear ap ro + * verification failures. */ - if (board_uses_closed_source_set1() || - board_has_ec_cr50_comm_support()) { - /* Enable interrupt handler for reset button combo */ - task_enable_irq(GC_IRQNUM_RBOX0_INTR_BUTTON_COMBO0_RDY_INT); - GWRITE_FIELD(RBOX, INT_ENABLE, INTR_BUTTON_COMBO0_RDY, 1); - } + task_enable_irq(GC_IRQNUM_RBOX0_INTR_BUTTON_COMBO0_RDY_INT); + GWRITE_FIELD(RBOX, INT_ENABLE, INTR_BUTTON_COMBO0_RDY, 1); /* * Note that the AP, EC, and servo state machines do not have explicit |