summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVic Yang <victoryang@chromium.org>2013-05-25 12:41:20 +0800
committerChromeBot <chrome-bot@google.com>2013-05-28 12:54:01 -0700
commiteb18f65941265b4c71a256a7610c36416df10032 (patch)
tree014f9e1d5e6f2a39136062de8cd897f87fe3569e
parentf4654f6d996449a6c9f1947bb6bb3760fa2a47eb (diff)
downloadchrome-ec-eb18f65941265b4c71a256a7610c36416df10032.tar.gz
spring: Fix a bug that 3.3V output is on after video dongle detached
Also remove the TODO for using ADC watchdog, which proves to cause ID voltage shift. BUG=None TEST=None BRANCH=spring Change-Id: Ic664c478c3c6751f84ad1aacd81a8c286deebeb9 Signed-off-by: Vic Yang <victoryang@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/56677 Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
-rw-r--r--common/extpower_usb.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/common/extpower_usb.c b/common/extpower_usb.c
index 97f74c64bb..bb6f37d1e4 100644
--- a/common/extpower_usb.c
+++ b/common/extpower_usb.c
@@ -692,10 +692,6 @@ static void pwm_tweak(void)
}
DECLARE_HOOK(HOOK_SECOND, pwm_tweak, HOOK_PRIO_DEFAULT);
-/*
- * TODO(victoryang): Get rid of polling loop when ADC watchdog is ready.
- * See crosbug.com/p/18171
- */
static void usb_monitor_detach(void)
{
int vbus;
@@ -709,6 +705,7 @@ static void usb_monitor_detach(void)
msleep(DELAY_ID_MUX_MS);
tsu6721_enable_interrupts();
usb_device_change(TSU6721_TYPE_NONE);
+ return;
}
/* Check if there is external power */