summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@chromium.org>2014-09-06 06:55:07 -0700
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2014-09-08 23:08:03 +0000
commit10042d9c5c3a32f3707e689a2bbc3270f38ee5b8 (patch)
tree7f69d7befd0f2bc143eb8878e32ae274097c5179
parent724e361a4271fb9546c27755e123641a0b7aa2ae (diff)
downloadchrome-ec-10042d9c5c3a32f3707e689a2bbc3270f38ee5b8.tar.gz
samus: Rename PCH_HDA_SDO GPIO
This was inverted in the schematic, but is also connected to a FET and is expected to be driven. However it is not working properly so for now leave the GPIO as an input. BUG=chrome-os-partner:31833 BRANCH=None TEST=build and boot on samus EVT Change-Id: I10d6a40b1102df866a9d32c52a9f67eb24c3ce7a Signed-off-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/216942 Reviewed-by: Alec Berg <alecaberg@chromium.org>
-rw-r--r--board/samus/gpio.inc6
1 files changed, 1 insertions, 5 deletions
diff --git a/board/samus/gpio.inc b/board/samus/gpio.inc
index 28bbb436c4..4066137427 100644
--- a/board/samus/gpio.inc
+++ b/board/samus/gpio.inc
@@ -46,6 +46,7 @@ GPIO(USB1_STATUS_L, E, 6, GPIO_INPUT, NULL) /* USB charger port 1 status output
GPIO(USB2_OC_L, E, 0, GPIO_INPUT, NULL) /* USB port overcurrent warning */
GPIO(USB2_STATUS_L, D, 7, GPIO_INPUT, NULL) /* USB charger port 2 status output */
GPIO(PD_IN_RW, A, 5, GPIO_INPUT, NULL) /* PD is in RW */
+GPIO(PCH_HDA_SDO_L, G, 1, GPIO_INPUT, NULL) /* HDA_SDO signal to PCH to disable ME */
/* Outputs; all unasserted by default except for reset signals */
GPIO(CPU_PROCHOT, B, 1, GPIO_OUT_LOW, NULL) /* Force CPU to think it's overheated */
@@ -68,11 +69,6 @@ GPIO(LIGHTBAR_RESET_L, J, 2, GPIO_ODR_LOW, NULL) /* Reset lightbar controlle
GPIO(PCH_DPWROK, G, 0, GPIO_OUT_LOW, NULL) /* Indicate when VccDSW is good */
GPIO(PCH_RSMRST_L, C, 4, GPIO_OUT_LOW, NULL) /* Reset PCH resume power plane logic */
GPIO(PCH_RTCRST_L, J, 1, GPIO_ODR_HIGH, NULL) /* Reset PCH RTC well */
-/*
- * HDA_SDO is technically an output, but we need to leave it as an
- * input until we drive it high. So can't use open-drain (HI_Z).
- */
-GPIO(PCH_HDA_SDO, G, 1, GPIO_INPUT, NULL) /* HDA_SDO signal to PCH; when high, ME ignores security descriptor */
GPIO(PCH_WAKE_L, F, 0, GPIO_ODR_HIGH, NULL) /* Wake signal from EC to PCH */
GPIO(PCH_NMI_L, F, 2, GPIO_ODR_HIGH, NULL) /* Non-maskable interrupt pin to PCH */
GPIO(PCH_PWRBTN_L, H, 0, GPIO_ODR_HIGH, NULL) /* Power button output to PCH */