diff options
| author | Keith Short <keithshort@chromium.org> | 2020-10-02 09:27:50 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-10-03 01:14:40 +0000 |
| commit | 6604329314d9ba2c10de111fd2b64a49366746cc (patch) | |
| tree | df4bb5e411016abe4e78697e219aafd251f34ad2 | |
| parent | f232f68a057815fae13c55c86e46d252e820f8d8 (diff) | |
| download | chrome-ec-6604329314d9ba2c10de111fd2b64a49366746cc.tar.gz | |
Revert "TCPMv2: Set mux state on updating partner's USB comm capability"
This reverts commit 181f23c9863e3350cb52c6e04490fbebd60e37eb.
Reason for revert: The original change causes bugs b:169346513 and
b:169935734
Original change's description:
> TCPMv2: Set mux state on updating partner's USB comm capability
>
> On updating the port partner's USB communication capability, the mux
> should also be configured into USB/disconnect mode accordingly. Hence,
> this CL sets the mux setting according to the partner's USB capability.
>
> BUG=b:157163664
> BRANCH=None
> TEST=Able to update the mux state on updating the port part USB comm
> capability.
>
> Signed-off-by: Ayushee <ayushee.shah@intel.com>
> Change-Id: Ic2d27e2a0af6dad54a875a589b85f8a5d583b5b4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2388972
> Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
> Reviewed-by: Keith Short <keithshort@chromium.org>
BUG=b:169346513, b:169935734
BRANCH=none
TEST=connect servoV4 to Volteer, confirm USB devices shown in kernel
TEST=connect PD charger to port C1, verify charging starts
Change-Id: I7bfda36a52aaa80c3faae1ab44b8b431431a2b97
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2445453
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| -rw-r--r-- | common/usbc/usb_tc_drp_acc_trysrc_sm.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/common/usbc/usb_tc_drp_acc_trysrc_sm.c b/common/usbc/usb_tc_drp_acc_trysrc_sm.c index 01264bd71f..97d69b0876 100644 --- a/common/usbc/usb_tc_drp_acc_trysrc_sm.c +++ b/common/usbc/usb_tc_drp_acc_trysrc_sm.c @@ -770,12 +770,6 @@ void tc_partner_usb_comm(int port, int en) TC_SET_FLAG(port, TC_FLAGS_PARTNER_USB_COMM); else TC_CLR_FLAG(port, TC_FLAGS_PARTNER_USB_COMM); - - /* - * Update the mux setting according to the port partner's - * USB communication capability. - */ - set_usb_mux_with_current_data_role(port); } void tc_partner_dr_data(int port, int en) |