summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenis Brockus <dbrockus@google.com>2020-08-20 12:27:32 -0600
committerCommit Bot <commit-bot@chromium.org>2020-08-21 00:55:18 +0000
commitb8e8fd1a2757338a3b502f40e9aca442e5959f2e (patch)
treec7bdabe876b953aaa6834553b4b4ad2f139b64bb
parent4e65dfbc00b2b75a3436bb69148ca722d58b5252 (diff)
downloadchrome-ec-b8e8fd1a2757338a3b502f40e9aca442e5959f2e.tar.gz
TCPMv2: Do not send GetSnkCap if FRS is not enabled
GetSnkCap is only needed for FastRoleSwap BUG=none BRANCH=none TEST=PR_Swap DUT-DUT testing Signed-off-by: Denis Brockus <dbrockus@google.com> Change-Id: I51973dfbfbfe855d1027c3b1cec35a2ba06a7b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2367283 Tested-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
-rw-r--r--common/usbc/usb_pe_drp_sm.c11
1 files changed, 10 insertions, 1 deletions
diff --git a/common/usbc/usb_pe_drp_sm.c b/common/usbc/usb_pe_drp_sm.c
index eb3c3ea7b0..9863a87fba 100644
--- a/common/usbc/usb_pe_drp_sm.c
+++ b/common/usbc/usb_pe_drp_sm.c
@@ -2574,8 +2574,17 @@ static void pe_snk_select_capability_run(int port)
/*
* Setup to get Device Policy Manager to
* request Sink Capabilities for possible FRS
+ *
+ * TODO(b:165822172) This should be called for
+ * FRS and non-FRS but there is a problem
+ * currently with the GetSnkCap functionality
+ * that is stopping PRS from working. The
+ * bug mentioned is to fix this path and
+ * re-enable for all.
*/
- pe_dpm_request(port, DPM_REQUEST_GET_SNK_CAPS);
+ if (IS_ENABLED(CONFIG_USB_PD_FRS))
+ pe_dpm_request(port,
+ DPM_REQUEST_GET_SNK_CAPS);
return;
}
/*