diff options
| author | Denis Brockus <dbrockus@google.com> | 2020-12-28 11:34:39 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-12-28 22:06:48 +0000 |
| commit | ec792c5ee08e3ddf55ba0b55c4cea22e3a3f8308 (patch) | |
| tree | 6d90adcd6a192090e41a9b1213e28b99b237681c | |
| parent | b5e260c96d9a5eba4fe82a67b5a59ab79d406071 (diff) | |
| download | chrome-ec-ec792c5ee08e3ddf55ba0b55c4cea22e3a3f8308.tar.gz | |
TCPMv2: Unit Test - remove unused out parameter
In an earlier cleanup, the need for returning the
original transmit type value became no longer
needed. So remove it.
BUG=none
BRANCH=none
TEST=make builadll
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I8fe30d7a9a87325bda6c4da6b4a5070b2d3ee6c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2604560
Tested-by: Denis Brockus <dbrockus@chromium.org>
Auto-Submit: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
| -rw-r--r-- | common/mock/tcpci_i2c_mock.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/common/mock/tcpci_i2c_mock.c b/common/mock/tcpci_i2c_mock.c index 816f382757..8f123f1fc7 100644 --- a/common/mock/tcpci_i2c_mock.c +++ b/common/mock/tcpci_i2c_mock.c @@ -147,8 +147,7 @@ static int verify_transmit(enum tcpm_transmit_type want_tx_type, int want_tx_retry, enum pd_ctrl_msg_type want_ctrl_msg, enum pd_data_msg_type want_data_msg, - int timeout, - uint16_t *old_transmit) + int timeout) { uint64_t end_time = get_time().val + timeout; @@ -184,10 +183,6 @@ static int verify_transmit(enum tcpm_transmit_type want_tx_type, TEST_GE(pd_cnt, 1, "%d"); } - if (old_transmit) - *old_transmit = - tcpci_regs[TCPC_REG_TRANSMIT].value; - tcpci_regs[TCPC_REG_TRANSMIT].value = 0; return EC_SUCCESS; } @@ -203,7 +198,7 @@ int verify_tcpci_transmit(enum tcpm_transmit_type tx_type, { return verify_transmit(tx_type, -1, ctrl_msg, data_msg, - VERIFY_TIMEOUT, NULL); + VERIFY_TIMEOUT); } int verify_tcpci_tx_timeout(enum tcpm_transmit_type tx_type, @@ -213,7 +208,7 @@ int verify_tcpci_tx_timeout(enum tcpm_transmit_type tx_type, { return verify_transmit(tx_type, -1, ctrl_msg, data_msg, - timeout, NULL); + timeout); } int verify_tcpci_tx_retry_count(enum tcpm_transmit_type tx_type, @@ -223,7 +218,7 @@ int verify_tcpci_tx_retry_count(enum tcpm_transmit_type tx_type, { return verify_transmit(tx_type, retry_count, ctrl_msg, data_msg, - VERIFY_TIMEOUT, NULL); + VERIFY_TIMEOUT); } void mock_tcpci_receive(enum pd_msg_type sop, uint16_t header, |