diff options
| author | Duncan Laurie <dlaurie@chromium.org> | 2013-08-09 13:45:46 -0700 |
|---|---|---|
| committer | ChromeBot <chrome-bot@google.com> | 2013-08-09 13:52:01 -0700 |
| commit | 34d762320a7a32dce472e87694702b5f586b1db7 (patch) | |
| tree | c24e784033b5fbd898aec45d43af3e0c42de1cf8 | |
| parent | e8b1473f7bde1fc40e2ea185a8378e55aa4c2b6f (diff) | |
| download | chrome-ec-34d762320a7a32dce472e87694702b5f586b1db7.tar.gz | |
Remove unneeded includes of registers.h
The registers.h file should only be included by code in the chip/ and
board/ directories. Code outside those directories should not access
chip-specific registers.
(This change doesn't completely fix that, because
common/extpower_usb.c uses STM32-specific regs, but we'll fix that in
a separate CL.)
BUG=chrome-os-partner:18343
BRANCH=none
TEST=compile all platforms
Original-Change-Id: Ic499f56690c38663083423b0593800161a68e6e9
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/64382
Reviewed-by: Vic Yang <victoryang@chromium.org>
(cherry picked from commit 078dfabb68be3573185bffdd79ef0f079002ee1e)
Change-Id: I0882950c7e81e0bd4114dd1b17371cf061504818
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/65368
| -rw-r--r-- | common/chipset_haswell.c | 1 | ||||
| -rw-r--r-- | common/flash_common.c | 1 | ||||
| -rw-r--r-- | common/keyboard_8042.c | 1 | ||||
| -rw-r--r-- | core/cortex-m/watchdog.c | 1 |
4 files changed, 0 insertions, 4 deletions
diff --git a/common/chipset_haswell.c b/common/chipset_haswell.c index 4e142a3e13..c5e5dec78c 100644 --- a/common/chipset_haswell.c +++ b/common/chipset_haswell.c @@ -11,7 +11,6 @@ #include "console.h" #include "gpio.h" #include "hooks.h" -#include "registers.h" #include "system.h" #include "timer.h" #include "util.h" diff --git a/common/flash_common.c b/common/flash_common.c index 082f64fb75..57bb09e0c9 100644 --- a/common/flash_common.c +++ b/common/flash_common.c @@ -10,7 +10,6 @@ #include "flash.h" #include "gpio.h" #include "host_command.h" -#include "registers.h" #include "shared_mem.h" #include "system.h" #include "util.h" diff --git a/common/keyboard_8042.c b/common/keyboard_8042.c index 67073b23ef..a31c8a2783 100644 --- a/common/keyboard_8042.c +++ b/common/keyboard_8042.c @@ -17,7 +17,6 @@ #include "lpc.h" #include "power_button.h" #include "queue.h" -#include "registers.h" #include "shared_mem.h" #include "system.h" #include "task.h" diff --git a/core/cortex-m/watchdog.c b/core/cortex-m/watchdog.c index ff876912d1..8366f48d0a 100644 --- a/core/cortex-m/watchdog.c +++ b/core/cortex-m/watchdog.c @@ -7,7 +7,6 @@ #include "common.h" #include "panic.h" -#include "registers.h" #include "task.h" #include "timer.h" #include "uart.h" |