diff options
| author | Fabio Baltieri <fabiobaltieri@google.com> | 2020-12-29 11:53:01 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-08-20 03:56:10 +0000 |
| commit | ff725242c738aec29ea16dd12d6f1aff821a5db4 (patch) | |
| tree | 759b0bc95e455abda62b2ad932343e4f9d40da78 | |
| parent | 6d0f31f1dbc631d586ab25368b52cd84a02b3b4b (diff) | |
| download | chrome-ec-ff725242c738aec29ea16dd12d6f1aff821a5db4.tar.gz | |
ectool_keyscan: add missing null terminator to kbd_plain_xlate
strchr relies on the source string to be null terminated. This fixes a
compiler warning when building outside of the chroot:
util/ectool_keyscan.c: In function ‘cmd_keyscan’:
util/ectool_keyscan.c:208:9: error: ‘strchr’ argument missing terminating nul [-Werror=stringop-overflow=]
208 | pos = strchr(kbd_plain_xlate, key);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
BUG=none
TEST=build only, warning is gone
BRANCH=none
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Change-Id: Iafb8249515ffa1a5f7e04a272e54a048eef9a57c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2606228
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3105735
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
| -rw-r--r-- | util/ectool_keyscan.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/ectool_keyscan.c b/util/ectool_keyscan.c index 46ba221f6e..49745aa2c6 100644 --- a/util/ectool_keyscan.c +++ b/util/ectool_keyscan.c @@ -137,7 +137,7 @@ static const unsigned char kbd_plain_xlate[] = { '8', '9', '-', '4', '5', '6', '+', '1', /* 0x40 - 0x4f */ '2', '3', '0', '.', 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, /* 0x50 - 0x5F */ - '\r', 0xff, 0xff + '\r', 0xff, 0xff, '\0' }; /** |