diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2022-04-07 23:06:11 +0000 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-04-12 19:40:09 +0000 |
| commit | ddfb436d7199bd186c2f806da5e83b1bf439672f (patch) | |
| tree | d690d39eacf4158a3c14662b73b812acd0353273 | |
| parent | e308b1db1171d60e8695621fdf21d47495f157b8 (diff) | |
| download | chrome-ec-ddfb436d7199bd186c2f806da5e83b1bf439672f.tar.gz | |
RGBKBD: Print error code in set_color_single
This patch makes set_color_single print error code returned from a
driver.
BUG=b:228525798
BRANCH=None
TEST=Taniks
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: I8582b4c19c19b8a6dcdf83827f73610b650066ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3577988
Reviewed-by: Parth Malkan <parthmalkan@google.com>
| -rw-r--r-- | common/rgb_keyboard.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/common/rgb_keyboard.c b/common/rgb_keyboard.c index 4edbcac3a8..29f5563463 100644 --- a/common/rgb_keyboard.c +++ b/common/rgb_keyboard.c @@ -38,16 +38,17 @@ uint8_t rgbkbd_table[EC_RGBKBD_MAX_KEY_COUNT]; static int set_color_single(struct rgb_s color, int x, int y) { struct rgbkbd *ctx = &rgbkbds[0]; - uint8_t gid; + uint8_t grid; uint8_t col = 0; uint8_t offset; + int rv; if (rgbkbd_hsize <= x || rgbkbd_vsize <= y) { return EC_ERROR_OVERFLOW; } /* Search the grid where x belongs to. */ - for (gid = 0; gid < rgbkbd_count; gid++, ctx++) { + for (grid = 0; grid < rgbkbd_count; grid++, ctx++) { if (x < col + ctx->cfg->col_len) break; col += ctx->cfg->col_len; @@ -56,9 +57,13 @@ static int set_color_single(struct rgb_s color, int x, int y) offset = ctx->cfg->row_len * (x - col) + y; ctx->buf[offset] = color; - CPRINTS("Set [%d,%d] to color=[%d,%d,%d] (gid=%u offset=%u)", - x, y, color.r, color.g, color.b, gid, offset); - return ctx->cfg->drv->set_color(ctx, offset, &ctx->buf[offset], 1); + rv = ctx->cfg->drv->set_color(ctx, offset, &ctx->buf[offset], 1); + + CPRINTS("%set (%d,%d) to color=(%d,%d,%d) grid=%u offset=%u (%d)", + rv ? "Failed to s" : "S", + x, y, color.r, color.g, color.b, grid, offset, rv); + + return rv; } test_export_static uint8_t get_grid_size(const struct rgbkbd *ctx) |