diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2022-04-07 23:06:11 +0000 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-04-13 18:45:15 +0000 |
| commit | e4309526ab80157e886fb61ad2b7da00104c6d8c (patch) | |
| tree | 63da034a32ae39df22a533a426cd66b58851b282 | |
| parent | f4134044af7328f25b56aec0e2e12018d37b4bb7 (diff) | |
| download | chrome-ec-e4309526ab80157e886fb61ad2b7da00104c6d8c.tar.gz | |
Taniks: Support keyboard backlight control
This patch makes Taniks support keyboard backlight control through
EC_CMD_PWM_SET_DUTY, ACPI, and EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT.
BUG=b:228525798,b:226215987
BRANCH=None
TEST=Taniks
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: If1d27668297e809e8b7c28fc7f4caf0fa8d869e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3576898
Reviewed-by: Parth Malkan <parthmalkan@google.com>
| -rw-r--r-- | board/taniks/board.h | 4 | ||||
| -rw-r--r-- | board/taniks/pwm.c | 19 |
2 files changed, 2 insertions, 21 deletions
diff --git a/board/taniks/board.h b/board/taniks/board.h index b9016cdbbb..07780d90f2 100644 --- a/board/taniks/board.h +++ b/board/taniks/board.h @@ -179,7 +179,8 @@ #define GPIO_WP_L GPIO_EC_WP_ODL /* System has back-lit keyboard */ -#define CONFIG_PWM_KBLIGHT +#define CONFIG_PWM +#define CONFIG_KEYBOARD_BACKLIGHT /* I2C Bus Configuration */ #define I2C_PORT_SENSOR NPCX_I2C_PORT0_0 @@ -294,7 +295,6 @@ enum battery_type { }; enum pwm_channel { - PWM_CH_KBLIGHT = 0, /* PWM3 */ PWM_CH_FAN, /* PWM5 */ PWM_CH_COUNT }; diff --git a/board/taniks/pwm.c b/board/taniks/pwm.c index b5fef384f9..7e834385bf 100644 --- a/board/taniks/pwm.c +++ b/board/taniks/pwm.c @@ -11,17 +11,6 @@ #include "pwm_chip.h" const struct pwm_t pwm_channels[] = { - [PWM_CH_KBLIGHT] = { - .channel = 3, - .flags = 0, - /* - * Set PWM frequency to multiple of 50 Hz and 60 Hz to prevent - * flicker. Higher frequencies consume similar average power to - * lower PWM frequencies, but higher frequencies record a much - * lower maximum power. - */ - .freq = 2400, - }, [PWM_CH_FAN] = { .channel = 5, .flags = PWM_CONFIG_OPEN_DRAIN, @@ -29,11 +18,3 @@ const struct pwm_t pwm_channels[] = { }, }; BUILD_ASSERT(ARRAY_SIZE(pwm_channels) == PWM_CH_COUNT); - -static void board_pwm_init(void) -{ - - pwm_enable(PWM_CH_KBLIGHT, 1); - pwm_set_duty(PWM_CH_KBLIGHT, 50); -} -DECLARE_HOOK(HOOK_INIT, board_pwm_init, HOOK_PRIO_DEFAULT); |