diff options
| author | Tom Hughes <tomhughes@chromium.org> | 2021-10-07 16:45:02 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-10-08 01:30:13 +0000 |
| commit | 7cb20f372fa4ee7a5c98dfd39e06daeed24d67ca (patch) | |
| tree | 053740b9830b65257e2d91b55c3afbdca5e4aca5 | |
| parent | 151a967b4514e4bb1f56e5c40b9c392341b92afa (diff) | |
| download | chrome-ec-7cb20f372fa4ee7a5c98dfd39e06daeed24d67ca.tar.gz | |
board/primus: Fix enum type
When building with clang, it warns:
board/primus/usbc_config.c:138:16: error: implicit conversion from enumeration
type 'enum gpio_signal' to different enumeration type 'enum ioex_signal'
[-Werror,-Wenum-conversion]
rst_signal = GPIO_USB_C0_RT_RST_ODL;
~ ^~~~~~~~~~~~~~~~~~~~~~
board/primus/usbc_config.c:140:16: error: implicit conversion from enumeration
type 'enum gpio_signal' to different enumeration type 'enum ioex_signal'
[-Werror,-Wenum-conversion]
rst_signal = GPIO_USB_C1_RT_RST_ODL;
~ ^~~~~~~~~~~~~~~~~~~~~~
board/primus/usbc_config.c:157:18: error: implicit conversion from enumeration
type 'enum ioex_signal' to different enumeration type 'enum gpio_signal'
[-Werror,-Wenum-conversion]
gpio_set_level(rst_signal, 1);
~~~~~~~~~~~~~~ ^~~~~~~~~~
board/primus/usbc_config.c:167:18: error: implicit conversion from enumeration
type 'enum ioex_signal' to different enumeration type 'enum gpio_signal'
[-Werror,-Wenum-conversion]
gpio_set_level(rst_signal, 0);
~~~~~~~~~~~~~~ ^~~~~~~~~~
BRANCH=none
BUG=b:172020503
TEST=make CC=arm-none-eabi-clang BOARD=primus
TEST=./util/compare_build.sh -b primus
=> MATCH
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I6ed40493cdce6f972300f4b9c7f49f136c6a0026
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3213108
Reviewed-by: caveh jalali <caveh@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| -rw-r--r-- | board/primus/usbc_config.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/primus/usbc_config.c b/board/primus/usbc_config.c index 6e5c14bb0d..a2d076ae2d 100644 --- a/board/primus/usbc_config.c +++ b/board/primus/usbc_config.c @@ -132,7 +132,7 @@ void config_usb_db_type(void) __override int bb_retimer_power_enable(const struct usb_mux *me, bool enable) { - enum ioex_signal rst_signal; + enum gpio_signal rst_signal; if (me->usb_port == USBC_PORT_C0) { rst_signal = GPIO_USB_C0_RT_RST_ODL; |