diff options
| author | Al Semjonovs <asemjonovs@google.com> | 2023-04-10 11:57:05 -0600 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-04-12 14:52:12 +0000 |
| commit | d2d6f12754db9634996a4171edb51c1c642e3cfa (patch) | |
| tree | 3ecaaaa5ef781876b1c08f62eca60b67eb887427 | |
| parent | e06fe77101c2cea6f0ed51e108c39315c3729971 (diff) | |
| download | chrome-ec-d2d6f12754db9634996a4171edb51c1c642e3cfa.tar.gz | |
presubmit: Validate test_ prefix is present for ZTEST
Fail presubmit when 'test_' prefix is missing for new ZTESTs
BUG=None
BRANCH=NONE
TEST=Preupload check with
ZTEST(foo, test_good)
ZTEST(foo, missing_prefix1)
ZTEST_F(foo, missing_prefix2)
ZTEST_USER(foo , missing_prefix3)
ZTEST_USER_F(foo , missing_prefix4)
Change-Id: I0f223852159151d4fe7895e70b6c0548a44e1f45
Signed-off-by: Al Semjonovs <asemjonovs@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4411762
Reviewed-by: Aaron Massey <aaronmassey@google.com>
| -rwxr-xr-x | util/presubmit_check.sh | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/util/presubmit_check.sh b/util/presubmit_check.sh index 0fcd4a3319..b6ffa80a35 100755 --- a/util/presubmit_check.sh +++ b/util/presubmit_check.sh @@ -19,3 +19,11 @@ if git diff --no-ext-diff "${upstream_branch}" HEAD | echo "error: CPRINTS strings should not include newline characters" >&2 exit 1 fi + +# Check for missing 'test_' prefix from ZTEST definitions +if git diff --no-ext-diff "${upstream_branch}" HEAD | + pcregrep -M "^\+(ZTEST|ZTEST_F|ZTEST_USER|ZTEST_USER_F)\(\w+,[\n\+|\s]*\w+\)" | + pcregrep -vM "\(\w+,[\n\+]*\s*test_\w+\)"; then + echo "error: 'test_' prefix missing from test function name" >&2 + exit 1 +fi |