diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2017-08-24 09:03:46 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2017-12-16 01:13:26 +0000 |
| commit | 3142591036d51d9ce245cd0aa66d4902e7ac52e1 (patch) | |
| tree | 9cfd87d8e0d9676c5a85896805c762a139634c0a | |
| parent | f2c3504af3606ebd52f429049ed51d9c260f1951 (diff) | |
| download | chrome-ec-3142591036d51d9ce245cd0aa66d4902e7ac52e1.tar.gz | |
g: Change rdd 0.4V ref to 0.3V.
On some boards, it was seen that SuzyQable wasn't detected by the rdd
block. The voltage around 0.4V is marginal with a Vbus around 4.75V.
This commit simply adjust the 0.4V comparator reference voltage to 0.3V
in order to make the detection work.
Conflicts:
chip/g/rdd.c
BUG=b:64847312
BRANCH=cr50
TEST=Find a soraka where SuzyQable didn't work. Verify with this patch,
it does work. Additionally, verify that servo_v4 continues works.
Change-Id: If54630ec469408031cd84ffb93ef5fea42bdee3b
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/633403
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
(cherry picked from commit abd7e7d5820c114dee87565b93d5d76c209b3361)
Reviewed-on: https://chromium-review.googlesource.com/828691
Tested-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
| -rw-r--r-- | chip/g/rdd.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/chip/g/rdd.c b/chip/g/rdd.c index bd0d2360d8..211f492a01 100644 --- a/chip/g/rdd.c +++ b/chip/g/rdd.c @@ -78,6 +78,13 @@ void rdd_init(void) GWRITE(RDD, PROG_DEBUG_STATE_MAP, DETECT_DEBUG); + /* + * Set the 0.4V comparator reference to 0.3V instead. The voltage is + * marginal near 0.4V for example with VBUS at 4.75V and a SuzyQable See + * b/64847312. + */ + GWRITE_FIELD(RDD, REF_ADJ, LVL0P4V, 0x2); + /* Initialize the debug state based on the current cc values */ rdd_interrupt(); |