diff options
| author | Vadim Bendebury <vbendeb@chromium.org> | 2017-09-14 12:56:15 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2017-09-15 22:31:47 +0000 |
| commit | 7fab738e377bb37dc9efaa559509f6f46d24b3d8 (patch) | |
| tree | 80646c5c6817d23861cbee07da4bb43322bfb051 | |
| parent | c12a51fc97c085da445b56f88c8871023fbf8cca (diff) | |
| download | chrome-ec-7fab738e377bb37dc9efaa559509f6f46d24b3d8.tar.gz | |
util: fix bug in tagbranch
After mulptiple edits of the script, there is a case when bash
variable is not properly quoted, let's fix it.
BRANCH=cr50
BUG=b:64698702
TEST=verified proper tag description set by git
Change-Id: I5847437cde717bb6e1f4b672fe6008b8e6e6f4e3
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/667917
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
(cherry picked from commit 4fdccb6de5131475fb6ccd3402812e008091afa3)
Reviewed-on: https://chromium-review.googlesource.com/668820
(cherry picked from commit 0ddc5fa840c142a955087a5b5e36217139b3fb3f)
Reviewed-on: https://chromium-review.googlesource.com/669055
| -rwxr-xr-x | util/tagbranch.sh | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/util/tagbranch.sh b/util/tagbranch.sh index bcc71a4806..3e196b6f25 100755 --- a/util/tagbranch.sh +++ b/util/tagbranch.sh @@ -67,7 +67,8 @@ TAG="v1.${TAG_BASE}.0" BASE_SHA="$(git rev-list --ancestry-path "${BRANCH_POINT}".."${UPSTREAM}" | tail -1)" -if git tag -a -m 'firmware branch ${TAG}' "${TAG}" "${BASE_SHA}"; then +echo "Will run git tag -a -m \"firmware branch ${TAG}\" ${TAG} ${BASE_SHA}" +if git tag -a -m "firmware branch ${TAG}" "${TAG}" "${BASE_SHA}"; then cat <<EOF A new tag '$TAG' has been set. Use the following command |