diff options
| author | Namyoon Woo <namyoon@chromium.org> | 2020-12-07 11:35:34 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-02-25 16:58:15 +0000 |
| commit | 034f610c05f8745125e31fc057ea220f33309dd9 (patch) | |
| tree | 7ea65d48db235c0a1e173d242ea2809c43fef490 | |
| parent | bfe38dd4fe24fc8485d4f14e0788c8b072cbca8e (diff) | |
| download | chrome-ec-034f610c05f8745125e31fc057ea220f33309dd9.tar.gz | |
Reland "cr50: fix the comment on DIOB3 (EC_PACKET_MODE)"
This is a reland of e0879d9ccddac0c5dc7589b711ab7575326f231f
Original change's description:
> cr50: fix the comment on DIOB3 (EC_PACKET_MODE)
>
> DIOB3 (EC_PACKET_MODE) is used to indicate the start or the end of
> EC PACKET mode, but not as a UART TX.
> This patch corrects the incorrect comment regarding that.
>
> BUG=none
> TEST=none
>
> Signed-off-by: Namyoon Woo <namyoon@chromium.org>
> Change-Id: Ic13d34910005c8bc79a3f00e8d32113f267d6752
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2575291
> Reviewed-by: Mary Ruthven <mruthven@chromium.org>
> Commit-Queue: Mary Ruthven <mruthven@chromium.org>
> (cherry picked from commit a75a2f19db500bcd1ede45e49db3a422e4ed768f)
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2669407
> Tested-by: Mary Ruthven <mruthven@chromium.org>
> (cherry picked from commit c27ccf4686ca6a4546c0f2fdf4da014bbbd4242a)
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2713836
Bug: none
Change-Id: I21cad0236af125b896415750518b5af8f4844c23
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2718505
Tested-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Commit-Queue: Mary Ruthven <mruthven@chromium.org>
| -rw-r--r-- | common/ec_comm.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common/ec_comm.c b/common/ec_comm.c index c06e72ce3b..ea07c6cfd5 100644 --- a/common/ec_comm.c +++ b/common/ec_comm.c @@ -120,7 +120,7 @@ static uint16_t decode_packet_(const struct cr50_comm_packet *ph, int bytes) } /* - * Transfer a 'response' to 'uart' port using DIOB3 pin. + * Transfer a 'response' to 'uart' port. * * @param response Response code to return to EC. Should be one of * CR50_COMM_RESPONSE codes in include/vboot.h. @@ -134,7 +134,7 @@ static void transfer_response_to_ec_(uint16_t response) uartn_write_char(uart, ptr_resp[0]); uartn_write_char(uart, ptr_resp[1]); - uartn_tx_flush(uart); /* Flush from UART2_TX to DIOB3 */ + uartn_tx_flush(uart); ec_comm_ctx.last_resp = response; } |