diff options
| author | Scott Collyer <scollyer@chromium.org> | 2022-09-09 01:23:00 +0000 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-09-09 02:57:36 +0000 |
| commit | cd87c3cf0ebec7a3989ccbb3d9257b5ed19583b0 (patch) | |
| tree | 73aa341e55844b7ae44964228d261595856b97ba | |
| parent | fc7174c22872be43335c3d34c070f04e254ca643 (diff) | |
| download | chrome-ec-cd87c3cf0ebec7a3989ccbb3d9257b5ed19583b0.tar.gz | |
Revert "retimer: Adjust delay after taking BB/HB out of reset"
This reverts commit 862f688c797dcd05239237fbf30eb7ef3e730803.
Reason for revert: The delay added is too long for the remainder of the retimer initialization. A subsequent CL will be uploaded to fix the i2c error read issue.
Original change's description:
> retimer: Adjust delay after taking BB/HB out of reset
>
> This CL increases the delay in the power enable routine after taking
> the retimer out of reset. Without this additional delay, the first
> read of HB will fail.
>
> BRANCH=none
> BUG=b:244874682
> TEST=Verifed that after increasing the delay, the errors seen reading
> the HB retimer following the power_enable call are resolved.
>
> Signed-off-by: Scott Collyer <scollyer@google.com>
> Change-Id: I04cb7dfb108f1ab1b49fcfb8aaf60d453f7051b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3873652
> Commit-Queue: Scott Collyer <scollyer@chromium.org>
> Tested-by: Scott Collyer <scollyer@chromium.org>
> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
Bug: b:244874682
Change-Id: Ifc0de52102f274bf787b26a0315b5d393cbb2c7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3885590
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Auto-Submit: Scott Collyer <scollyer@chromium.org>
Commit-Queue: Peter Marheine <pmarheine@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| -rw-r--r-- | driver/retimer/bb_retimer.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/driver/retimer/bb_retimer.c b/driver/retimer/bb_retimer.c index 8ce17b4a74..4123e76c23 100644 --- a/driver/retimer/bb_retimer.c +++ b/driver/retimer/bb_retimer.c @@ -146,10 +146,10 @@ __overridable int bb_retimer_power_enable(const struct usb_mux *me, bool enable) msleep(1); gpio_set_level(control->retimer_rst_gpio, 1); /* - * Allow 50 ms time for the retimer to power up lc_domain + * Allow 1ms time for the retimer to power up lc_domain * which powers I2C controller within retimer */ - msleep(50); + msleep(1); } else { gpio_set_level(control->retimer_rst_gpio, 0); msleep(1); |