summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjohnwc_yeh <johnwc_yeh@compal.corp-partner.google.com>2022-09-29 13:48:21 +0800
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2022-09-30 02:28:40 +0000
commitc147c6217d086b5042d6645109d1cc8ca7a02cf3 (patch)
treeef16ddde4e650fd5cb9e8c4acb3c7fe05cf336ba
parentc179b33ec485cd482469f120c978f2a432a7585e (diff)
downloadchrome-ec-c147c6217d086b5042d6645109d1cc8ca7a02cf3.tar.gz
Frostflow: Implement LED behavior
This patch modify led_policy and led_pins dts files for Frostflow. Implement LED behavior. Power LED: Discharge in S0 : White on Discharge in S3 : Blinking White, 1sec on /3sec off Discharge in S5 : Off Charge LED: Charge : Amber on Full charge : White on Battery Low(0~10%) in S0 : Blinking Amber, 1sec on /3sec off Battery Low(0~10%) in S3 : Blinking White, 1sec on /3sec off Battery Low(0~10%) in S5 : Off Battery Error in S0 : Blinking Amber, 1sec on /1sec off Battery Error in S3 : Blinking White, 1sec on /3sec off Battery Error in S5 : Off LOW_COVERAGE_REASON=Skyrim board tests not created yet: b/247151116 BUG=b:246874455 BRANCH=none TEST=zmake build frostflow Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Change-Id: Idae8b7a1b74d651d971992e454e4bc2e46b7951e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3928563 Reviewed-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-rw-r--r--zephyr/projects/skyrim/led_pins_frostflow.dts2
-rw-r--r--zephyr/projects/skyrim/led_policy_frostflow.dts71
2 files changed, 46 insertions, 27 deletions
diff --git a/zephyr/projects/skyrim/led_pins_frostflow.dts b/zephyr/projects/skyrim/led_pins_frostflow.dts
index 33a66c0756..d294490208 100644
--- a/zephyr/projects/skyrim/led_pins_frostflow.dts
+++ b/zephyr/projects/skyrim/led_pins_frostflow.dts
@@ -39,7 +39,7 @@
color_white: color-white {
led-color = "LED_WHITE";
led-id = "EC_LED_ID_BATTERY_LED";
- br-color = "EC_LED_COLOR_BLUE";
+ br-color = "EC_LED_COLOR_WHITE";
led-pins = <&pwm_y 0>,
<&pwm_w 100>;
};
diff --git a/zephyr/projects/skyrim/led_policy_frostflow.dts b/zephyr/projects/skyrim/led_policy_frostflow.dts
index a075c6b0d2..e5875640fb 100644
--- a/zephyr/projects/skyrim/led_policy_frostflow.dts
+++ b/zephyr/projects/skyrim/led_policy_frostflow.dts
@@ -1,22 +1,40 @@
-#include <dt-bindings/battery.h>
-
/ {
led-colors {
compatible = "cros-ec,led-policy";
power-state-charge {
charge-state = "PWR_STATE_CHARGE";
+ /* Battery percent range (>= Empty, <= 94%) */
+ batt-lvl = <0 94>;
color-0 {
led-color = <&color_amber>;
};
};
+ power-state-charge-lvl-2 {
+ charge-state = "PWR_STATE_CHARGE";
+ /* Battery percent range (>= 95%, <= Near Full) */
+ batt-lvl = <95 97>;
+
+ color-0 {
+ led-color = <&color_white>;
+ };
+ };
+
+ power-state-near-full {
+ charge-state = "PWR_STATE_CHARGE_NEAR_FULL";
+
+ color-0 {
+ led-color = <&color_white>;
+ };
+ };
+
power-state-discharge-s0 {
charge-state = "PWR_STATE_DISCHARGE";
chipset-state = "POWER_S0";
- /* Battery percent range (> Low, <= Full) */
- batt-lvl = <(BATTERY_LEVEL_LOW + 1) BATTERY_LEVEL_FULL>;
+ /* Battery percent range (>= 11%, <= Full) */
+ batt-lvl = <11 100>;
color-0 {
led-color = <&color_white>;
@@ -26,17 +44,17 @@
power-state-discharge-s0-batt-low {
charge-state = "PWR_STATE_DISCHARGE";
chipset-state = "POWER_S0";
- /* Battery percent range (>= Empty, <= Low) */
- batt-lvl = <BATTERY_LEVEL_EMPTY BATTERY_LEVEL_LOW>;
+ /* Battery percent range (>= Empty, <= 10%) */
+ batt-lvl = <0 10>;
- /* White 2 sec, off 1 sec */
+ /* Amber 1 sec, off 3 sec */
color-0 {
- led-color = <&color_white>;
- period-ms = <2000>;
+ led-color = <&color_amber>;
+ period-ms = <1000>;
};
color-1 {
led-color = <&color_off>;
- period-ms = <1000>;
+ period-ms = <3000>;
};
};
@@ -44,14 +62,14 @@
charge-state = "PWR_STATE_DISCHARGE";
chipset-state = "POWER_S3";
- /* White 1 sec, off 1 sec */
+ /* White 1 sec, off 3 sec */
color-0 {
led-color = <&color_white>;
period-ms = <1000>;
};
color-1 {
led-color = <&color_off>;
- period-ms = <1000>;
+ period-ms = <3000>;
};
};
@@ -64,9 +82,9 @@
};
};
- power-state-error {
+ power-state-error-s0 {
charge-state = "PWR_STATE_ERROR";
-
+ chipset-state = "POWER_S0";
/* Amber 1 sec, off 1 sec */
color-0 {
led-color = <&color_amber>;
@@ -78,25 +96,26 @@
};
};
- power-state-near-full {
- charge-state = "PWR_STATE_CHARGE_NEAR_FULL";
-
+ power-state-error-s3 {
+ charge-state = "PWR_STATE_ERROR";
+ chipset-state = "POWER_S3";
+ /* White 1 sec, off 3 sec */
color-0 {
led-color = <&color_white>;
+ period-ms = <1000>;
+ };
+ color-1 {
+ led-color = <&color_off>;
+ period-ms = <3000>;
};
};
- power-state-forced-idle {
- charge-state = "PWR_STATE_FORCED_IDLE";
+ power-state-error-s5 {
+ charge-state = "PWR_STATE_ERROR";
+ chipset-state = "POWER_S5";
- /* Amber 2 sec, White 2 sec */
color-0 {
- led-color = <&color_amber>;
- period-ms = <2000>;
- };
- color-1 {
- led-color = <&color_white>;
- period-ms = <2000>;
+ led-color = <&color_off>;
};
};
};