diff options
author | Joel Kitching <kitching@chromium.org> | 2018-06-25 21:41:13 +0000 |
---|---|---|
committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2018-06-25 21:41:44 +0000 |
commit | c2102ea3763d15ca009439b8ddfd3cfbed80b8d8 (patch) | |
tree | 01c121906db21683f15e285c82c12875704878fd | |
parent | 71c28ac8f98ab49e826c88a3ea2b4c4068cf7454 (diff) | |
download | chrome-ec-c2102ea3763d15ca009439b8ddfd3cfbed80b8d8.tar.gz |
Revert "ec_features: Move feature flags out of ec_command into its own unit"
This reverts commit 3970502067f625f41f96ae9d155270b0f50bfaba.
Reason for revert: Re-using 32-bit host events instead. See b/110292722
Original change's description:
> ec_features: Move feature flags out of ec_command into its own unit
>
> Prepare for exposing the feature flags through EC ACPI memory space by
> moving the definitions and collection function into its own unit.
>
> BUG=b:64705535
> BRANCH=none
> TEST=builds and returns the same value
>
> Change-Id: Ie393d732612f47e547a15cc72974974e27bb4824
> Signed-off-by: Patrick Georgi <pgeorgi@google.com>
> Reviewed-on: https://chromium-review.googlesource.com/633925
> Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
> Tested-by: Patrick Georgi <pgeorgi@chromium.org>
> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
> Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
> (cherry picked from commit 6844e4c2793b736b873f97510238ae6ed03c0772)
> Leaving out change from CL:540667 in common/host_command.c (renamed
> in this CL to common/ec_features.c), which marks EC_FEATURE_PMU as
> obsolete.
> Reviewed-on: https://chromium-review.googlesource.com/989862
> Reviewed-by: Joel Kitching <kitching@chromium.org>
> Commit-Queue: Joel Kitching <kitching@chromium.org>
> Tested-by: Joel Kitching <kitching@chromium.org>
> Trybot-Ready: Joel Kitching <kitching@chromium.org>
Bug: b:64705535
Change-Id: I8f235a338ea6202ca1a29bc70f26bdbc239bac25
Reviewed-on: https://chromium-review.googlesource.com/1113788
Reviewed-by: Joel Kitching <kitching@chromium.org>
Commit-Queue: Joel Kitching <kitching@chromium.org>
Tested-by: Joel Kitching <kitching@chromium.org>
Trybot-Ready: Joel Kitching <kitching@chromium.org>
-rw-r--r-- | common/build.mk | 2 | ||||
-rw-r--r-- | common/ec_features.c | 114 | ||||
-rw-r--r-- | common/host_command.c | 98 | ||||
-rw-r--r-- | include/host_command.h | 4 |
4 files changed, 97 insertions, 121 deletions
diff --git a/common/build.mk b/common/build.mk index b5a670cfcc..126cd7a3ef 100644 --- a/common/build.mk +++ b/common/build.mk @@ -112,7 +112,7 @@ common-$(CONFIG_WIRELESS)+=wireless.o common-$(HAS_TASK_CHIPSET)+=chipset.o common-$(HAS_TASK_CONSOLE)+=console.o console_output.o uart_buffering.o common-$(CONFIG_CMD_MEM)+=memory_commands.o -common-$(HAS_TASK_HOSTCMD)+=host_command.o ec_features.o +common-$(HAS_TASK_HOSTCMD)+=host_command.o common-$(HAS_TASK_PDCMD)+=host_command_pd.o common-$(HAS_TASK_KEYSCAN)+=keyboard_scan.o common-$(HAS_TASK_LIGHTBAR)+=lb_common.o lightbar.o diff --git a/common/ec_features.c b/common/ec_features.c deleted file mode 100644 index 9a630e6f17..0000000000 --- a/common/ec_features.c +++ /dev/null @@ -1,114 +0,0 @@ -/* Copyright 2017 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ - -/* Present Chrome EC device features to the outside world */ - -#include "common.h" -#include "ec_commands.h" - -uint32_t get_feature_flags0(void) -{ - return 0 -#ifdef CONFIG_FW_LIMITED_IMAGE - | EC_FEATURE_MASK_0(EC_FEATURE_LIMITED) -#endif -#ifdef CONFIG_FLASH - | EC_FEATURE_MASK_0(EC_FEATURE_FLASH) -#endif -#ifdef CONFIG_FANS - | EC_FEATURE_MASK_0(EC_FEATURE_PWM_FAN) -#endif -#ifdef CONFIG_PWM_KBLIGHT - | EC_FEATURE_MASK_0(EC_FEATURE_PWM_KEYB) -#endif -#ifdef HAS_TASK_LIGHTBAR - | EC_FEATURE_MASK_0(EC_FEATURE_LIGHTBAR) -#endif -#ifdef CONFIG_LED_COMMON - | EC_FEATURE_MASK_0(EC_FEATURE_LED) -#endif -#ifdef HAS_TASK_MOTIONSENSE - | EC_FEATURE_MASK_0(EC_FEATURE_MOTION_SENSE) -#endif -#ifdef HAS_TASK_KEYSCAN - | EC_FEATURE_MASK_0(EC_FEATURE_KEYB) -#endif -#ifdef CONFIG_PSTORE - | EC_FEATURE_MASK_0(EC_FEATURE_PSTORE) -#endif -#ifdef CONFIG_LPC - | EC_FEATURE_MASK_0(EC_FEATURE_PORT80) -#endif -#ifdef CONFIG_TEMP_SENSOR - | EC_FEATURE_MASK_0(EC_FEATURE_THERMAL) -#endif -/* Hack to uniquely identify Samus ec */ -#if (defined CONFIG_BACKLIGHT_LID) || (defined CONFIG_BATTERY_SAMUS) - | EC_FEATURE_MASK_0(EC_FEATURE_BKLIGHT_SWITCH) -#endif -#ifdef CONFIG_WIRELESS - | EC_FEATURE_MASK_0(EC_FEATURE_WIFI_SWITCH) -#endif -#ifdef CONFIG_HOSTCMD_EVENTS - | EC_FEATURE_MASK_0(EC_FEATURE_HOST_EVENTS) -#endif -#ifdef CONFIG_COMMON_GPIO - | EC_FEATURE_MASK_0(EC_FEATURE_GPIO) -#endif -#ifdef CONFIG_I2C_MASTER - | EC_FEATURE_MASK_0(EC_FEATURE_I2C) -#endif -#ifdef CONFIG_CHARGER - | EC_FEATURE_MASK_0(EC_FEATURE_CHARGER) -#endif -#if (defined CONFIG_BATTERY) || (defined CONFIG_BATTERY_SMART) - | EC_FEATURE_MASK_0(EC_FEATURE_BATTERY) -#endif -#ifdef CONFIG_BATTERY_SMART - | EC_FEATURE_MASK_0(EC_FEATURE_SMART_BATTERY) -#endif -#ifdef CONFIG_AP_HANG_DETECT - | EC_FEATURE_MASK_0(EC_FEATURE_HANG_DETECT) -#endif -#if 0 - | EC_FEATURE_MASK_0(EC_FEATURE_PMU) /* Obsolete */ -#endif -#ifdef CONFIG_HOSTCMD_PD - | EC_FEATURE_MASK_0(EC_FEATURE_SUB_MCU) -#endif -#ifdef CONFIG_CHARGE_MANAGER - | EC_FEATURE_MASK_0(EC_FEATURE_USB_PD) -#endif -#ifdef CONFIG_ACCEL_FIFO - | EC_FEATURE_MASK_0(EC_FEATURE_MOTION_SENSE_FIFO) -#endif -#ifdef CONFIG_VSTORE - | EC_FEATURE_MASK_0(EC_FEATURE_VSTORE) -#endif -#ifdef CONFIG_USB_MUX_VIRTUAL - | EC_FEATURE_MASK_0(EC_FEATURE_USBC_SS_MUX_VIRTUAL) -#endif -#ifdef CONFIG_HOSTCMD_RTC - | EC_FEATURE_MASK_0(EC_FEATURE_RTC) -#endif -#ifdef CONFIG_SPI_FP_PORT - | EC_FEATURE_MASK_0(EC_FEATURE_FINGERPRINT) -#endif -#ifdef HAS_TASK_CENTROIDING - | EC_FEATURE_MASK_0(EC_FEATURE_TOUCHPAD) -#endif -#ifdef HAS_TASK_RWSIG - | EC_FEATURE_MASK_0(EC_FEATURE_RWSIG) -#endif -#ifdef CONFIG_DEVICE_EVENT - | EC_FEATURE_MASK_0(EC_FEATURE_DEVICE_EVENT) -#endif - ; -} - -uint32_t get_feature_flags1(void) -{ - return 0; -} diff --git a/common/host_command.c b/common/host_command.c index 812c930272..68f2867cf7 100644 --- a/common/host_command.c +++ b/common/host_command.c @@ -8,7 +8,6 @@ #include "ap_hang_detect.h" #include "common.h" #include "console.h" -#include "ec_commands.h" #include "host_command.h" #include "link_defs.h" #include "lpc.h" @@ -714,7 +713,102 @@ static int host_command_get_features(struct host_cmd_handler_args *args) args->response_size = sizeof(*r); memset(r, 0, sizeof(*r)); - r->flags[0] = get_feature_flags0(); + r->flags[0] = 0 +#ifdef CONFIG_FW_LIMITED_IMAGE + | EC_FEATURE_MASK_0(EC_FEATURE_LIMITED) +#endif +#ifdef CONFIG_FLASH + | EC_FEATURE_MASK_0(EC_FEATURE_FLASH) +#endif +#ifdef CONFIG_FANS + | EC_FEATURE_MASK_0(EC_FEATURE_PWM_FAN) +#endif +#ifdef CONFIG_PWM_KBLIGHT + | EC_FEATURE_MASK_0(EC_FEATURE_PWM_KEYB) +#endif +#ifdef HAS_TASK_LIGHTBAR + | EC_FEATURE_MASK_0(EC_FEATURE_LIGHTBAR) +#endif +#ifdef CONFIG_LED_COMMON + | EC_FEATURE_MASK_0(EC_FEATURE_LED) +#endif +#ifdef HAS_TASK_MOTIONSENSE + | EC_FEATURE_MASK_0(EC_FEATURE_MOTION_SENSE) +#endif +#ifdef HAS_TASK_KEYSCAN + | EC_FEATURE_MASK_0(EC_FEATURE_KEYB) +#endif +#ifdef CONFIG_PSTORE + | EC_FEATURE_MASK_0(EC_FEATURE_PSTORE) +#endif +#ifdef CONFIG_LPC + | EC_FEATURE_MASK_0(EC_FEATURE_PORT80) +#endif +#ifdef CONFIG_TEMP_SENSOR + | EC_FEATURE_MASK_0(EC_FEATURE_THERMAL) +#endif +/* Hack to uniquely identify Samus ec */ +#if (defined CONFIG_BACKLIGHT_LID) || (defined CONFIG_BATTERY_SAMUS) + | EC_FEATURE_MASK_0(EC_FEATURE_BKLIGHT_SWITCH) +#endif +#ifdef CONFIG_WIRELESS + | EC_FEATURE_MASK_0(EC_FEATURE_WIFI_SWITCH) +#endif +#ifdef CONFIG_HOSTCMD_EVENTS + | EC_FEATURE_MASK_0(EC_FEATURE_HOST_EVENTS) +#endif +#ifdef CONFIG_COMMON_GPIO + | EC_FEATURE_MASK_0(EC_FEATURE_GPIO) +#endif +#ifdef CONFIG_I2C_MASTER + | EC_FEATURE_MASK_0(EC_FEATURE_I2C) +#endif +#ifdef CONFIG_CHARGER + | EC_FEATURE_MASK_0(EC_FEATURE_CHARGER) +#endif +#if (defined CONFIG_BATTERY) || (defined CONFIG_BATTERY_SMART) + | EC_FEATURE_MASK_0(EC_FEATURE_BATTERY) +#endif +#ifdef CONFIG_BATTERY_SMART + | EC_FEATURE_MASK_0(EC_FEATURE_SMART_BATTERY) +#endif +#ifdef CONFIG_AP_HANG_DETECT + | EC_FEATURE_MASK_0(EC_FEATURE_HANG_DETECT) +#endif +#ifdef CONFIG_PMU_POWERINFO + | EC_FEATURE_MASK_0(EC_FEATURE_PMU) +#endif +#ifdef CONFIG_HOSTCMD_PD + | EC_FEATURE_MASK_0(EC_FEATURE_SUB_MCU) +#endif +#ifdef CONFIG_CHARGE_MANAGER + | EC_FEATURE_MASK_0(EC_FEATURE_USB_PD) +#endif +#ifdef CONFIG_ACCEL_FIFO + | EC_FEATURE_MASK_0(EC_FEATURE_MOTION_SENSE_FIFO) +#endif +#ifdef CONFIG_VSTORE + | EC_FEATURE_MASK_0(EC_FEATURE_VSTORE) +#endif +#ifdef CONFIG_USB_MUX_VIRTUAL + | EC_FEATURE_MASK_0(EC_FEATURE_USBC_SS_MUX_VIRTUAL) +#endif +#ifdef CONFIG_HOSTCMD_RTC + | EC_FEATURE_MASK_0(EC_FEATURE_RTC) +#endif +#ifdef CONFIG_SPI_FP_PORT + | EC_FEATURE_MASK_0(EC_FEATURE_FINGERPRINT) +#endif +#ifdef HAS_TASK_CENTROIDING + | EC_FEATURE_MASK_0(EC_FEATURE_TOUCHPAD) +#endif +#ifdef HAS_TASK_RWSIG + | EC_FEATURE_MASK_0(EC_FEATURE_RWSIG) +#endif +#ifdef CONFIG_DEVICE_EVENT + | EC_FEATURE_MASK_0(EC_FEATURE_DEVICE_EVENT) +#endif + ; return EC_RES_SUCCESS; } DECLARE_HOST_COMMAND(EC_CMD_GET_FEATURES, diff --git a/include/host_command.h b/include/host_command.h index 78157231ca..50466dc61d 100644 --- a/include/host_command.h +++ b/include/host_command.h @@ -313,8 +313,4 @@ int host_get_vboot_mode(void); */ void host_send_sysrq(uint8_t key); -/* Return the lower/higher part of the feature flags bitmap */ -uint32_t get_feature_flags0(void); -uint32_t get_feature_flags1(void); - #endif /* __CROS_EC_HOST_COMMAND_H */ |