diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2018-02-13 13:13:13 -0800 |
|---|---|---|
| committer | Daisuke Nojiri <dnojiri@chromium.org> | 2018-02-19 10:33:13 -0800 |
| commit | 2ec462ccd023e78debeb6f14cebd96b81a7ada54 (patch) | |
| tree | 84bfb4e652bf33c66aa5a8267f414fbd234452c0 | |
| parent | 6b1dbfe8812c18cf0a0e43f8b7b48d7715331713 (diff) | |
| download | chrome-ec-2ec462ccd023e78debeb6f14cebd96b81a7ada54.tar.gz | |
grunt: Remove pull-up on UART pins.
BUG=b:73135908
BRANCH=None
TEST=Flash grunt; verify EC UART still functional. Reboot Cr50 a bunch
without servo connected, verify that Cr50 never reports servo as
"connected".
Change-Id: I1ec402b4e3d0e9debdbb2af3a1ba5e1c45aa655a
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/917182
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
| -rw-r--r-- | board/grunt/gpio.inc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/board/grunt/gpio.inc b/board/grunt/gpio.inc index de75bbcbc1..76dfca8b3e 100644 --- a/board/grunt/gpio.inc +++ b/board/grunt/gpio.inc @@ -92,7 +92,8 @@ GPIO(SKU_ID1, PIN(F, 0), GPIO_INPUT) GPIO(SKU_ID2, PIN(4, 1), GPIO_INPUT) /* Alternate functions GPIO definitions */ -ALTERNATE(PIN_MASK(6, 0x30), 0, MODULE_UART, GPIO_PULL_UP) /* UART from EC to Servo */ +/* Cr50 requires no pull-ups on UART pins. */ +ALTERNATE(PIN_MASK(6, 0x30), 0, MODULE_UART, 0) /* UART from EC to Servo */ ALTERNATE(PIN_MASK(B, 0x30), 1, MODULE_I2C, 0) /* I2C0 */ ALTERNATE(PIN_MASK(9, 0x07), 1, MODULE_I2C, 0) /* I2C1 SCL / I2C2 */ ALTERNATE(PIN_MASK(8, 0x80), 1, MODULE_I2C, 0) /* I2C1 SDA */ |