diff options
| author | Robert Zieba <robertzieba@google.com> | 2023-05-02 17:16:54 +0000 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-05-09 22:55:34 +0000 |
| commit | 7540daff3f1d60e2193e5cb7d86ba2f8769520da (patch) | |
| tree | a086b892fb8d0410b5553d597df18487cf119c1a | |
| parent | db79044cfe8eb8e486e8e50cd5bebbdec3a143ec (diff) | |
| download | chrome-ec-7540daff3f1d60e2193e5cb7d86ba2f8769520da.tar.gz | |
driver/tcpm/nct38xx: Remove write to RO register
`TCPC_REG_DEV_CAP_2` is a RO register according to the TCPC spec and the
NCT38xx datasheet. Writes to this register have no effect on real
hardware. The vendor has also confirmed that they are not aware of any
workarounds that would explain this write. Remove it.
BUG=b:280351196
TEST=Ran on skyrim, verified that FRS sequences don't change
Change-Id: I9364f66c3499a7a49b41c9edad6cd6ef970e6a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4507893
Tested-by: Robert Zieba <robertzieba@google.com>
Auto-Submit: Robert Zieba <robertzieba@google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
| -rw-r--r-- | driver/tcpm/nct38xx.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/driver/tcpm/nct38xx.c b/driver/tcpm/nct38xx.c index 120749fb62..3c4565cfd5 100644 --- a/driver/tcpm/nct38xx.c +++ b/driver/tcpm/nct38xx.c @@ -115,11 +115,6 @@ static int nct38xx_init(int port) /* Set FRS direction for SNK detect, if FRS is enabled */ if (tcpm_tcpc_has_frs_control(port)) { - reg = TCPC_REG_DEV_CAP_2_SNK_FR_SWAP; - rv = tcpc_write(port, TCPC_REG_DEV_CAP_2, reg); - if (rv) - return rv; - reg = TCPC_REG_CONFIG_EXT_1_FR_SWAP_SNK_DIR; rv = tcpc_write(port, TCPC_REG_CONFIG_EXT_1, reg); if (rv) |