diff options
| author | Simon Glass <sjg@chromium.org> | 2023-05-04 15:39:34 -0600 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-05-09 22:29:29 +0000 |
| commit | d9882c4480138004a3e51f5ba96c026e3542ea4f (patch) | |
| tree | 0a994213d17b78ece236033f851d2fdece372352 | |
| parent | ddbc094311765a55cf4cc52e0c7594e2a7f6891e (diff) | |
| download | chrome-ec-d9882c4480138004a3e51f5ba96c026e3542ea4f.tar.gz | |
charger: Make prev_full a local var
This does not need to be global to the whole file. Move it into the
charging loop.
This makes no functional change.
BUG=b:218332694
TEST=zmake build dev-posix
Change-Id: Ia9e5b4e202535e6b3f9277a66cbdbc87c984d95e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4508348
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
| -rw-r--r-- | common/charge_state_v2.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/common/charge_state_v2.c b/common/charge_state_v2.c index 2b54f5db3b..596f7a445d 100644 --- a/common/charge_state_v2.c +++ b/common/charge_state_v2.c @@ -84,7 +84,7 @@ static uint8_t battery_level_shutdown; static const struct battery_info *batt_info; static struct charge_state_data curr; static enum charge_state_v2 prev_state; -static int prev_ac, prev_charge, prev_full, prev_disp_charge; +static int prev_ac, prev_charge, prev_disp_charge; static enum battery_present prev_bp; static int is_full; /* battery not accepting current */ static enum ec_charge_control_mode chg_ctl_mode; @@ -1723,7 +1723,7 @@ static void base_check_extpower(void) } /* check for and handle any state-of-charge change with the battery */ -void check_battery_change_soc(void) +void check_battery_change_soc(bool prev_full) { if ((!(curr.batt.flags & BATT_FLAG_BAD_STATE_OF_CHARGE) && curr.batt.state_of_charge != prev_charge) || @@ -2114,6 +2114,7 @@ void charger_task(void *u) int need_static = 1; const struct charger_info *const info = charger_get_info(); int chgnum = 0; + bool prev_full = false; /* Set up the task - note that charger_init() has already run. */ charger_setup(info); @@ -2158,7 +2159,7 @@ void charger_task(void *u) /* Run battery soc check for setting the current limit. */ current_limit_battery_soc(); - check_battery_change_soc(); + check_battery_change_soc(prev_full); prev_full = is_full; |