diff options
| author | Vadim Bendebury <vbendeb@chromium.org> | 2016-04-29 18:51:01 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-05-02 17:35:45 -0700 |
| commit | 455767f08fe81dd8932e6868f748fea5ae50a30f (patch) | |
| tree | 3aee8f9c83c0d99fae4c691e4596bfb4dd74b509 | |
| parent | 42662f2214aa43982d44edd4dc12721d6f77e018 (diff) | |
| download | chrome-ec-455767f08fe81dd8932e6868f748fea5ae50a30f.tar.gz | |
g: fix debug messages not to include two newlines
The CPRITS() macro adds newline to all strings, there is no need to
explicitly add newlines.
BRANCH=none
BUG=none
TEST=usb upgrade debug messages do not span two lines any more
Change-Id: I1991214ddaa5945bedba861d67b392973f6a3d0f
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/341615
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
| -rw-r--r-- | chip/g/usb_upgrade.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/chip/g/usb_upgrade.c b/chip/g/usb_upgrade.c index bca76d401e..df3d34ca11 100644 --- a/chip/g/usb_upgrade.c +++ b/chip/g/usb_upgrade.c @@ -120,19 +120,19 @@ static void upgrade_out_handler(struct consumer const *consumer, size_t count) block_buffer = NULL; } rx_state_ = rx_idle; - CPRINTS("FW update: recovering after timeout\n"); + CPRINTS("FW update: recovering after timeout"); } if (rx_state_ == rx_idle) { /* This better be the first block, of zero size. */ if (count != sizeof(struct update_pdu_header)) { - CPRINTS("FW update: wrong first block size %d\n", + CPRINTS("FW update: wrong first block size %d", count); return; } QUEUE_REMOVE_UNITS(consumer->queue, &updu, count); - CPRINTS("FW update: starting...\n"); + CPRINTS("FW update: starting..."); fw_upgrade_command_handler(&updu.cmd, count - offsetof(struct update_pdu_header, @@ -176,7 +176,7 @@ static void upgrade_out_handler(struct consumer const *consumer, size_t count) sizeof(command)); command = be32toh(command); if (command == UPGRADE_DONE) { - CPRINTS("FW update: done\n"); + CPRINTS("FW update: done"); resp_value = 0; QUEUE_ADD_UNITS(&upgrade_to_usb, &resp_value, sizeof(resp_value)); @@ -186,7 +186,7 @@ static void upgrade_out_handler(struct consumer const *consumer, size_t count) } if (count < sizeof(updu)) { - CPRINTS("FW update: error: first chunk of %d bytes\n", + CPRINTS("FW update: error: first chunk of %d bytes", count); rx_state_ = rx_idle; return; @@ -200,7 +200,7 @@ static void upgrade_out_handler(struct consumer const *consumer, size_t count) if (shared_mem_acquire(block_size, (char **)&block_buffer) != EC_SUCCESS) { /* TODO:(vbendeb) report out of memory here. */ - CPRINTS("FW update: error: failed to alloc %d bytes.\n", + CPRINTS("FW update: error: failed to alloc %d bytes.", block_size); return; } |