diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2018-02-13 13:10:46 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-02-14 17:05:31 -0800 |
| commit | 9b83436b147482593e4770b1c7daabfdd0fabc8b (patch) | |
| tree | ce8f09221345615aa6efec3af9dd990a7122e408 | |
| parent | dc170640c7edc2bc0c4ff54f6ffe844a082424c9 (diff) | |
| download | chrome-ec-9b83436b147482593e4770b1c7daabfdd0fabc8b.tar.gz | |
meowth: zoombini: Remove internal pullups on UART.
Cr50 requires no pullups on the EC UART pins.
BUG=b:73135908
BRANCH=None
TEST=Flash meowth; Reboot Cr50 a bunch, verify that servo is never seen
as "connected".
Change-Id: I88e4a2e510c1c795f2b240c3d742a7466acf696b
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/917181
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
| -rw-r--r-- | board/zoombini/gpio.inc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/board/zoombini/gpio.inc b/board/zoombini/gpio.inc index 025841e1d9..97ed24ab49 100644 --- a/board/zoombini/gpio.inc +++ b/board/zoombini/gpio.inc @@ -96,7 +96,7 @@ GPIO(BOARD_VERSION2, PIN(9, 3), GPIO_INPUT) GPIO(BOARD_VERSION3, PIN(F, 0), GPIO_INPUT) /* UART Pins */ -ALTERNATE(PIN_MASK(6, 0x30), 0, MODULE_UART, GPIO_PULL_UP) +ALTERNATE(PIN_MASK(6, 0x30), 0, MODULE_UART, 0) /* Cr50 requires no pullups. */ /* I2C Ports */ ALTERNATE(PIN_MASK(B, 0x30), 1, MODULE_I2C, 0) /* I2C0 */ ALTERNATE(PIN_MASK(9, 0x06), 1, MODULE_I2C, 0) /* I2C2 */ @@ -199,7 +199,7 @@ GPIO(BOARD_VERSION2, PIN(9, 3), GPIO_INPUT) GPIO(BOARD_VERSION3, PIN(A, 2), GPIO_INPUT) /* UART Pins */ -ALTERNATE(PIN_MASK(6, 0x30), 0, MODULE_UART, GPIO_PULL_UP) +ALTERNATE(PIN_MASK(6, 0x30), 0, MODULE_UART, 0) /* Cr50 requires no pullups. */ /* I2C Ports */ ALTERNATE(PIN_MASK(B, 0x30), 1, MODULE_I2C, 0) /* I2C0 */ ALTERNATE(PIN_MASK(9, 0x01), 1, MODULE_I2C, 0) /* I2C1 SDA */ |