summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDoug Anderson <dianders@chromium.org>2014-06-19 13:32:15 -0700
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2014-06-23 16:58:13 +0000
commit37c394fbc9166e171f9b96290cf2543395e3456e (patch)
treec04777ec7547ada56d7e11d51f18ddd9c733d2b9
parent2476adf0604a20c59e41793f4b488c72c645be8c (diff)
downloadchrome-ec-37c394fbc9166e171f9b96290cf2543395e3456e.tar.gz
watchdog: Give more leeway to the independent watchdog
It would be really nice to be guaranteed to see watchdog warnings before we actually hit a watchdog reset even if something strange is going on with the CPU. Let's increase the margin between the timer and the independent so that the hardware watchdog is really hit as a last resort. It seems like a 1.6 second hardware watchdog wouldn't be the end of the world so let's bump that way rather than increasing the number of warnings. BRANCH=ToT BUG=chrome-os-partner:29162 TEST="waitms 1000" on EC console no longer ever reboots. Change-Id: Ic5e5ddec22fb8484cc7c552b19d3f2043c105d0c Signed-off-by: Doug Anderson <dianders@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/204716 Reviewed-by: Randall Spangler <rspangler@chromium.org>
-rw-r--r--include/watchdog.h11
1 files changed, 6 insertions, 5 deletions
diff --git a/include/watchdog.h b/include/watchdog.h
index a0e76df5a4..400233eb24 100644
--- a/include/watchdog.h
+++ b/include/watchdog.h
@@ -8,14 +8,15 @@
#ifndef __CROS_EC_WATCHDOG_H
#define __CROS_EC_WATCHDOG_H
-/* Watchdog period in ms; must be at least twice HOOK_TICK_INTERVAL */
-#define WATCHDOG_PERIOD_MS 1100
+/* Watchdog period in ms; see also AUX_TIMER_PERIOD_MS */
+#define WATCHDOG_PERIOD_MS 1600
/*
- * Fire auxiliary timer 50ms before watchdog timer expires. This leaves
- * some time for debug trace to be printed.
+ * Fire auxiliary timer 500ms before watchdog timer expires. This leaves
+ * some time for debug trace to be printed; must be at least twice
+ * HOOK_TICK_INTERVAL.
*/
-#define AUX_TIMER_PERIOD_MS (WATCHDOG_PERIOD_MS - 50)
+#define AUX_TIMER_PERIOD_MS (WATCHDOG_PERIOD_MS - 500)
/**
* Initialize the watchdog.