summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Lee <mike5@huaqin.corp-partner.google.com>2020-12-10 22:45:43 +0800
committerCommit Bot <commit-bot@chromium.org>2020-12-15 10:51:05 +0000
commit2e10ddd8dadeddbe227438cf93f967862a125ab9 (patch)
treee2030dc2d0f99eb6b7f10ce10198214dd3d6d624
parentb46ecc1d668dcda230ba69ca6193f1f44d5d6740 (diff)
downloadchrome-ec-2e10ddd8dadeddbe227438cf93f967862a125ab9.tar.gz
Cerise: Enable DC-DC mode ctrl
Enable DC-DC mode ctrl to solve S3 power consumption over spec BUG=b:173343526 BRANCH=firmware-kukui-12573.B TEST=test S3 power consumption meet spec. Signed-off-by: Mike Lee <mike5@huaqin.corp-partner.google.com> Change-Id: Ia9df2bbe9b86030243c399b8e2ffc2f9993f5e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2592533 Reviewed-by: Chen-Tsung Hsieh <chentsung@chromium.org> Commit-Queue: Chen-Tsung Hsieh <chentsung@chromium.org>
-rw-r--r--board/cerise/board.c19
-rw-r--r--board/cerise/gpio.inc2
2 files changed, 21 insertions, 0 deletions
diff --git a/board/cerise/board.c b/board/cerise/board.c
index 2f9fa19eda..a4fcc7490f 100644
--- a/board/cerise/board.c
+++ b/board/cerise/board.c
@@ -306,6 +306,9 @@ static void board_init(void)
/* Enable BC12 interrupt */
gpio_enable_interrupt(GPIO_BC12_EC_INT_ODL);
+
+ /* Enable USM mode */
+ ioex_set_level(IOEX_5V_DC_DC_MODE_CTRL, 1);
}
DECLARE_HOOK(HOOK_INIT, board_init, HOOK_PRIO_DEFAULT);
@@ -429,6 +432,22 @@ static void board_chipset_shutdown(void)
}
DECLARE_HOOK(HOOK_CHIPSET_SHUTDOWN, board_chipset_shutdown, HOOK_PRIO_DEFAULT);
+/* Called on AP S3 -> S0 transition, 5V DC-DC ctrl */
+static void board_chipset_resume(void)
+{
+ /* Enable USM mode */
+ ioex_set_level(IOEX_5V_DC_DC_MODE_CTRL, 1);
+}
+DECLARE_HOOK(HOOK_CHIPSET_RESUME, board_chipset_resume, HOOK_PRIO_DEFAULT);
+
+/* Called on AP S0 -> S3 transition */
+static void board_chipset_suspend(void)
+{
+ /* Enable Normal mode */
+ ioex_set_level(IOEX_5V_DC_DC_MODE_CTRL, 0);
+}
+DECLARE_HOOK(HOOK_CHIPSET_SUSPEND, board_chipset_suspend, HOOK_PRIO_DEFAULT);
+
int board_get_charger_i2c(void)
{
/* TODO(b:138415463): confirm the bus allocation for future builds */
diff --git a/board/cerise/gpio.inc b/board/cerise/gpio.inc
index 51972ec367..fbc887f740 100644
--- a/board/cerise/gpio.inc
+++ b/board/cerise/gpio.inc
@@ -87,6 +87,8 @@ GPIO(USB_C0_DISCHARGE, PIN(B, 6), GPIO_OUT_LOW)
IOEX(PWR_LED_WHITE_L, EXPIN(0, 1, 4), GPIO_OUT_HIGH)
IOEX(BAT_LED_WHITE_L, EXPIN(0, 1, 3), GPIO_OUT_HIGH)
IOEX(BAT_LED_AMBER_L, EXPIN(0, 1, 2), GPIO_OUT_HIGH)
+IOEX(5V_DC_DC_MODE_CTRL, EXPIN(0, 0, 7), GPIO_OUT_LOW)
+
/*
* TODO(b:138352732): On IT88801 expander, To be readded once IT8801 driver and
* gpio expander framework has landed.