diff options
| author | Sue Chen <sue.chen@quanta.corp-partner.google.com> | 2019-07-18 12:03:48 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-07-18 17:23:14 +0000 |
| commit | 3b56f0b080711a9180f21af730be836c0628441c (patch) | |
| tree | fa9d9293d6c44a07a71117594dae55523f01a767 | |
| parent | bf9eae6ec8ab843c84bb21e5f360d01ee9bf8122 (diff) | |
| download | chrome-ec-3b56f0b080711a9180f21af730be836c0628441c.tar.gz | |
Nami: Clear EC_FEATURE_PWM_KEYB for the sku not supporting keyboard
backlight in Bard.
If sku_id is without SKU_ID_MASK_KBLIGHT, it should clear
EC_FEATURE_PWM_KEYB in feature flags0 to let the OS know that the device
does not support keyboard backlight.
BUG=b:137097125
BRANCH=nami
TEST=Make sure that keyboard backlight brightness scale won't show up
when sku id is without SKU_ID_MASK_KBLIGHT.
Change-Id: Ibe482a12c5113c430b585f8ad95366f222f8f939
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1709041
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Auto-Submit: Daisuke Nojiri <dnojiri@chromium.org>
| -rw-r--r-- | board/nami/board.c | 13 | ||||
| -rw-r--r-- | board/nami/board.h | 1 |
2 files changed, 14 insertions, 0 deletions
diff --git a/board/nami/board.c b/board/nami/board.c index 24e9ca079e..e81d88c3fe 100644 --- a/board/nami/board.c +++ b/board/nami/board.c @@ -1095,3 +1095,16 @@ enum critical_shutdown board_critical_shutdown_check( return CRITICAL_SHUTDOWN_HIBERNATE; } + +uint32_t board_override_feature_flags0(uint32_t flags0) +{ + if (!(sku & SKU_ID_MASK_KBLIGHT)) + return (flags0 & ~EC_FEATURE_MASK_0(EC_FEATURE_PWM_KEYB)); + + return flags0; +} + +uint32_t board_override_feature_flags1(uint32_t flags1) +{ + return flags1; +} diff --git a/board/nami/board.h b/board/nami/board.h index 1b20b7baae..f4c12a28b5 100644 --- a/board/nami/board.h +++ b/board/nami/board.h @@ -62,6 +62,7 @@ #define CONFIG_SUPPRESSED_HOST_COMMANDS \ EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY, \ EC_CMD_MOTION_SENSE_CMD +#define CONFIG_EC_FEATURE_BOARD_OVERRIDE /* EC console commands */ #define CONFIG_CMD_ACCELS |