summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Bettis <jbettis@google.com>2022-11-30 15:31:48 -0700
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2022-12-01 17:19:35 +0000
commit7f6f66043aef3910364f95eecca7760f5b4d3c51 (patch)
tree0c8c675b6aa821c7b6fd3630e36f56932d72feba
parent1b7905dc01c52a2873b076bacccd50a456024f68 (diff)
downloadchrome-ec-7f6f66043aef3910364f95eecca7760f5b4d3c51.tar.gz
twister: Allow wrapper to be used in make
To use the twister wrapper in GNU make and have the jobserver get passed down to twister, we need to keep the file descriptors open. BRANCH=None BUG=None TEST=Wrote makefile and added +./twister to it. Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I900c509e3c3736f4cea8a30bb9975627071ed816 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4068491 Reviewed-by: Tristan Honscheid <honscheid@google.com> Commit-Queue: Tristan Honscheid <honscheid@google.com> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-rwxr-xr-xutil/twister_launcher.py7
1 files changed, 6 insertions, 1 deletions
diff --git a/util/twister_launcher.py b/util/twister_launcher.py
index 11202f9343..77dab89adb 100755
--- a/util/twister_launcher.py
+++ b/util/twister_launcher.py
@@ -382,7 +382,12 @@ def main():
sys.stdout.flush()
# Invoke Twister and wait for it to exit.
- result = subprocess.run(twister_cli, env=twister_env, check=False)
+ result = subprocess.run(
+ twister_cli,
+ env=twister_env,
+ check=False,
+ close_fds=False, # For GNUMakefile jobserver
+ )
if check_for_skipped_tests(intercepted_args.outdir):
result.returncode = 1