summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDiana Z <dzigterman@chromium.org>2019-04-18 14:10:58 -0600
committerCommit Bot <commit-bot@chromium.org>2019-05-23 15:43:53 +0000
commit8a960d0d8b939e1840a4ca274e53d6183d55f4a5 (patch)
treed9c6cfdca2f3a242639c8d73e7e769c511646d98
parentf56efcd433c661920b3a7ce96438b44e23e6a0f9 (diff)
downloadchrome-ec-8a960d0d8b939e1840a4ca274e53d6183d55f4a5.tar.gz
Casta: Increase board_hibernate() wait to avoid hard resets
When hibernating with AC plugged in, casta will try negotiating down to 5V. This negotiation may sometimes take longer than the currently allocated sleep, causing the port partner to go into error recovery (re-sending PS_RDY, followed by soft resets, followed by a hard reset). This hard reset will wake the system back up from hibernation. Increasing this sleep to 300 ms appears to give enough time for a GoodCRC to be send to the PS_RDY message from the charger, avoiding the hard reset. Note that hibernating on AC is not a customer or factory requirement, as the typical EC hibernate scenario is when there is no external power and the battery needs to be conserved. BRANCH=octopus BUG=b:130687403 TEST=flashed to casta EVT, ran hibernate key sequence several times with AC plugged in and verified system hibernated Change-Id: Ia40ee63f3cf9a244ba35b4cc700e2b41eea1dde5 Signed-off-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1584768 Tested-by: YongBeum Ha <ybha@samsung.com> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: YongBeum Ha <ybha@samsung.com> (cherry picked from commit d3f26175e58a1686def18af02239b4693674bc8f) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1626312
-rw-r--r--baseboard/octopus/baseboard.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/baseboard/octopus/baseboard.c b/baseboard/octopus/baseboard.c
index 68e52ffcf7..1f5abc55f4 100644
--- a/baseboard/octopus/baseboard.c
+++ b/baseboard/octopus/baseboard.c
@@ -382,5 +382,5 @@ void board_hibernate(void)
* with any PD contract renegotiation, and tcpm to put TCPC into low
* power mode if required.
*/
- msleep(200);
+ msleep(300);
}