diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2015-09-24 15:11:36 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2016-08-25 20:58:29 +0000 |
| commit | 53fdd5d52e24a5e50e85fd127177ebd5d92be5ba (patch) | |
| tree | 9a4f36f955bee0e79703b5b95edc15f4aac14741 | |
| parent | 6c637141189dcf0207ba03b1516a748ed1eb68c6 (diff) | |
| download | chrome-ec-53fdd5d52e24a5e50e85fd127177ebd5d92be5ba.tar.gz | |
UPSTREAM: common: motion: Fix error calculating oversampling.
cl:298688 was wrong and oversampling calculation, used to drop
events that AP does not want was incorrect.
We were comparing mHz with Hz.
BUG=b:24367625, b:27849483
BRANCH=smaug, samus
TEST=Before, we would fail all
android.hardware.cts.SingleSensorTests#testAccelerometer tests where
frequency was lower than 100Hz. After, we pass thoses tests.
Change-Id: I487feb4e235a21f78d367397b5890ebcc5864b22
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/302176
Reviewed-by: Alec Berg <alecaberg@chromium.org>
(cherry picked from commit a0a1d18e06053b3cf2f390d31cd032560b184544)
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/370541
| -rw-r--r-- | common/motion_sense.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/motion_sense.c b/common/motion_sense.c index f72748091a..f05e8e91b0 100644 --- a/common/motion_sense.c +++ b/common/motion_sense.c @@ -93,7 +93,7 @@ void motion_sense_fifo_add_unit(struct ec_response_motion_sensor_data *data, /* For valid sensors, check if AP really needs this data */ if (valid_data) { - int ap_odr = BASE_ODR(sensor->config[SENSOR_CONFIG_AP].odr); + fp_t ap_odr = fp_div(BASE_ODR(sensor->config[SENSOR_CONFIG_AP].odr), 1000); /* Use integer, conversion to FP will overflow */ fp_t rate = fp_div(sensor->drv->get_data_rate(sensor), 1000); |