diff options
| author | Shelley Chen <shchen@google.com> | 2019-11-20 23:45:32 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-11-22 10:17:21 +0000 |
| commit | 5b30bc23812eb0d54789851a5b951b364d28f635 (patch) | |
| tree | 71a81b0a6a7ddeb24ff6aed467cc8f94cf841864 | |
| parent | e73c807595eba1bc1a1b575fb12f252522cffca3 (diff) | |
| download | chrome-ec-5b30bc23812eb0d54789851a5b951b364d28f635.tar.gz | |
all hatch variants: Assign SYS_RST_ODL to GPIOC5
There is an error where SYS_RST_ODL is assigned to GPIO02 where it is
actually assigned to GPIOC5 in the schematics. This should cause AP
reset to fail from the ec console.
BUG=b:141476349
BRANCH=hatch
TEST=None (I don't have a hatch board to test this out on)
Change-Id: I855a65489ce974ee92be4bf51a83d5af40e4e2da
Signed-off-by: Shelley Chen <shchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1928421
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Commit-Queue: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
| -rw-r--r-- | board/akemi/gpio.inc | 2 | ||||
| -rw-r--r-- | board/dratini/gpio.inc | 2 | ||||
| -rw-r--r-- | board/hatch/gpio.inc | 1 | ||||
| -rw-r--r-- | board/helios/gpio.inc | 2 | ||||
| -rw-r--r-- | board/kindred/gpio.inc | 2 |
5 files changed, 5 insertions, 4 deletions
diff --git a/board/akemi/gpio.inc b/board/akemi/gpio.inc index 14c44fd4f6..247724b2d2 100644 --- a/board/akemi/gpio.inc +++ b/board/akemi/gpio.inc @@ -41,7 +41,7 @@ GPIO_INT(USB_C1_BC12_INT_ODL, PIN(E, 4), GPIO_INT_FALLING, bc12_interrupt) GPIO_INT(EC_VOLDN_BTN_ODL, PIN(9, 3), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) GPIO_INT(EC_VOLUP_BTN_ODL, PIN(7, 5), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) -GPIO(SYS_RESET_L, PIN(0, 2), GPIO_ODR_HIGH) /* SYS_RST_ODL */ +GPIO(SYS_RESET_L, PIN(C, 5), GPIO_ODR_HIGH) /* SYS_RST_ODL */ GPIO(ENTERING_RW, PIN(E, 3), GPIO_OUT_LOW) /* EC_ENTERING_RW */ GPIO(PCH_WAKE_L, PIN(7, 4), GPIO_ODR_HIGH) /* EC_PCH_WAKE_ODL */ GPIO(PCH_PWRBTN_L, PIN(C, 1), GPIO_ODR_HIGH) /* EC_PCH_PWR_BTN_ODL */ diff --git a/board/dratini/gpio.inc b/board/dratini/gpio.inc index 558ceab351..8b7142da25 100644 --- a/board/dratini/gpio.inc +++ b/board/dratini/gpio.inc @@ -44,7 +44,7 @@ GPIO_INT(HDMI_CONN_HPD, PIN(7, 2), GPIO_INT_BOTH, hdmi_hpd_interrupt) GPIO_INT(EC_VOLDN_BTN_ODL, PIN(9, 3), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) GPIO_INT(EC_VOLUP_BTN_ODL, PIN(7, 5), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) -GPIO(SYS_RESET_L, PIN(0, 2), GPIO_ODR_HIGH) /* SYS_RST_ODL */ +GPIO(SYS_RESET_L, PIN(C, 5), GPIO_ODR_HIGH) /* SYS_RST_ODL */ GPIO(ENTERING_RW, PIN(E, 3), GPIO_OUT_LOW) /* EC_ENTERING_RW */ GPIO(PCH_WAKE_L, PIN(7, 4), GPIO_ODR_HIGH) /* EC_PCH_WAKE_ODL */ GPIO(PCH_PWRBTN_L, PIN(C, 1), GPIO_ODR_HIGH) /* EC_PCH_PWR_BTN_ODL */ diff --git a/board/hatch/gpio.inc b/board/hatch/gpio.inc index 4633b177a9..cd241f15f5 100644 --- a/board/hatch/gpio.inc +++ b/board/hatch/gpio.inc @@ -44,6 +44,7 @@ GPIO_INT(HDMI_CONN_HPD, PIN(7, 2), GPIO_INT_BOTH, hdmi_hpd_interrupt) GPIO_INT(EC_VOLDN_BTN_ODL, PIN(9, 3), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) GPIO_INT(EC_VOLUP_BTN_ODL, PIN(7, 5), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) +/* SYS_RESET_L should be set to GPIOC5 per schematics, but was never built, so leaving as GPIO02 */ GPIO(SYS_RESET_L, PIN(0, 2), GPIO_ODR_HIGH) /* SYS_RST_ODL */ GPIO(ENTERING_RW, PIN(E, 3), GPIO_OUT_LOW) /* EC_ENTERING_RW */ GPIO(PCH_WAKE_L, PIN(7, 4), GPIO_ODR_HIGH) /* EC_PCH_WAKE_ODL */ diff --git a/board/helios/gpio.inc b/board/helios/gpio.inc index 9e65dec865..90ad1478b6 100644 --- a/board/helios/gpio.inc +++ b/board/helios/gpio.inc @@ -42,7 +42,7 @@ GPIO_INT(USB_C1_BC12_INT_ODL, PIN(E, 4), GPIO_INT_FALLING, bc12_interrupt) GPIO_INT(EC_VOLDN_BTN_ODL, PIN(9, 3), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) GPIO_INT(EC_VOLUP_BTN_ODL, PIN(7, 5), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) -GPIO(SYS_RESET_L, PIN(0, 2), GPIO_ODR_HIGH) /* SYS_RST_ODL */ +GPIO(SYS_RESET_L, PIN(C, 5), GPIO_ODR_HIGH) /* SYS_RST_ODL */ GPIO(ENTERING_RW, PIN(E, 3), GPIO_OUT_LOW) /* EC_ENTERING_RW */ GPIO(PCH_WAKE_L, PIN(7, 4), GPIO_ODR_HIGH) /* EC_PCH_WAKE_ODL */ GPIO(PCH_PWRBTN_L, PIN(C, 1), GPIO_ODR_HIGH) /* EC_PCH_PWR_BTN_ODL */ diff --git a/board/kindred/gpio.inc b/board/kindred/gpio.inc index e20d59cfb2..c197eb9f28 100644 --- a/board/kindred/gpio.inc +++ b/board/kindred/gpio.inc @@ -43,7 +43,7 @@ GPIO_INT(HDMI_CONN_HPD, PIN(7, 2), GPIO_INT_BOTH, hdmi_hpd_interrupt) GPIO_INT(EC_VOLDN_BTN_ODL, PIN(9, 3), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) GPIO_INT(EC_VOLUP_BTN_ODL, PIN(7, 5), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) -GPIO(SYS_RESET_L, PIN(0, 2), GPIO_ODR_HIGH) /* SYS_RST_ODL */ +GPIO(SYS_RESET_L, PIN(C, 5), GPIO_ODR_HIGH) /* SYS_RST_ODL */ GPIO(ENTERING_RW, PIN(E, 3), GPIO_OUT_LOW) /* EC_ENTERING_RW */ GPIO(PCH_WAKE_L, PIN(7, 4), GPIO_ODR_HIGH) /* EC_PCH_WAKE_ODL */ GPIO(PCH_PWRBTN_L, PIN(C, 1), GPIO_ODR_HIGH) /* EC_PCH_PWR_BTN_ODL */ |