diff options
| author | Randall Spangler <rspangler@chromium.org> | 2014-02-10 16:08:33 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-02-13 21:55:31 +0000 |
| commit | de18658f25b69298a3f422bb9e1b4389a15b032f (patch) | |
| tree | eca62ffa6fd7bda89d3f8d86bf15525b0bcde23b | |
| parent | 3ee48b785f70837c9583ba8d417ec5355025d9e8 (diff) | |
| download | chrome-ec-de18658f25b69298a3f422bb9e1b4389a15b032f.tar.gz | |
baytrail: Battery cutoff return codes were backwards
cutoff() returns 0 on success, not non-zero.
BUG=chrome-os-partner:25646
BRANCH=None
TEST=ectool batterycutoff succeeds
Change-Id: I603931333c9955a81197d831c4cd3efa5b852ce3
Original-Change-Id: Icca0c53aba82381b73dd679de5df3a97153d0662
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/185737
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/186444
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Commit-Queue: Dave Parker <dparker@chromium.org>
Tested-by: Dave Parker <dparker@chromium.org>
| -rw-r--r-- | board/rambi/battery.c | 2 | ||||
| -rw-r--r-- | board/squawks/battery.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/board/rambi/battery.c b/board/rambi/battery.c index 622d903d22..3c031d6480 100644 --- a/board/rambi/battery.c +++ b/board/rambi/battery.c @@ -48,7 +48,7 @@ static int cutoff(void) static int battery_command_cut_off(struct host_cmd_handler_args *args) { - return cutoff() ? EC_RES_SUCCESS : EC_RES_ERROR; + return cutoff() ? EC_RES_ERROR : EC_RES_SUCCESS; } DECLARE_HOST_COMMAND(EC_CMD_BATTERY_CUT_OFF, battery_command_cut_off, EC_VER_MASK(0)); diff --git a/board/squawks/battery.c b/board/squawks/battery.c index 156818d7fd..7c8d140d5b 100644 --- a/board/squawks/battery.c +++ b/board/squawks/battery.c @@ -53,7 +53,7 @@ static int cutoff(void) static int battery_command_cut_off(struct host_cmd_handler_args *args) { - return cutoff() ? EC_RES_SUCCESS : EC_RES_ERROR; + return cutoff() ? EC_RES_ERROR : EC_RES_SUCCESS; } DECLARE_HOST_COMMAND(EC_CMD_BATTERY_CUT_OFF, battery_command_cut_off, EC_VER_MASK(0)); |