diff options
author | Vic (Chun-Ju) Yang <victoryang@chromium.org> | 2013-11-27 15:28:34 +0800 |
---|---|---|
committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-12-04 13:34:53 +0000 |
commit | 715ad86d43f0695363d3749f2c202f5e3f7e3bd2 (patch) | |
tree | e9a66b85917db0ae71b3feb062e7ef2720df0492 | |
parent | 36eb70c637e0221542f63170139613a52ba71e98 (diff) | |
download | chrome-ec-715ad86d43f0695363d3749f2c202f5e3f7e3bd2.tar.gz |
mec1322: temporary hack for using EMI module
We are using EMI module instead of LPC memory transaction. This requires
a different protocol for accessing mapped memory from host. For easier
development, let's add a new comm-mec1322.c until we can switch back to
LPC memory transaction.
BUG=chrome-os-partner:24280
TEST=ectool version
TEST=util/make_all.sh
BRANCH=None
Change-Id: Id8914d0413561991d3e46bef7e3fe76c4f8b83e4
Signed-off-by: Vic (Chun-Ju) Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/178251
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
-rw-r--r-- | util/build.mk | 4 | ||||
-rw-r--r-- | util/comm-mec1322.c | 349 |
2 files changed, 352 insertions, 1 deletions
diff --git a/util/build.mk b/util/build.mk index 29beb3ef75..0cd5cbecc8 100644 --- a/util/build.mk +++ b/util/build.mk @@ -9,7 +9,9 @@ host-util-bin=ectool lbplay burn_my_ec comm-objs=$(util-lock-objs:%=lock/%) comm-host.o comm-dev.o -ifeq ($(CONFIG_LPC),y) +ifeq ($(CHIP),mec1322) +comm-objs+=comm-mec1322.o +else ifeq ($(CONFIG_LPC),y) comm-objs+=comm-lpc.o else comm-objs+=comm-i2c.o diff --git a/util/comm-mec1322.c b/util/comm-mec1322.c new file mode 100644 index 0000000000..d4b2c3ad00 --- /dev/null +++ b/util/comm-mec1322.c @@ -0,0 +1,349 @@ +/* Copyright (c) 2013 The Chromium OS Authors. All rights reserved. + * Use of this source code is governed by a BSD-style license that can be + * found in the LICENSE file. + */ + +/* This is a temporary HACK for MEC1322. */ + +/* TODO(crosbug.com/p/24280): Remove this file and use comm-lpc.c */ + +#include <stdint.h> +#include <stdio.h> +#include <sys/io.h> +#include <sys/param.h> +#include <unistd.h> + +#include "comm-host.h" + +#define INITIAL_UDELAY 5 /* 5 us */ +#define MAXIMUM_UDELAY 10000 /* 10 ms */ + +/* + * Wait for the EC to be unbusy. Returns 0 if unbusy, non-zero if + * timeout. + */ +static int wait_for_ec(int status_addr, int timeout_usec) +{ + int i; + int delay = INITIAL_UDELAY; + + for (i = 0; i < timeout_usec; i += delay) { + /* + * Delay first, in case we just sent out a command but the EC + * hasn't raised the busy flag. However, I think this doesn't + * happen since the LPC commands are executed in order and the + * busy flag is set by hardware. Minor issue in any case, + * since the initial delay is very short. + */ + usleep(MIN(delay, timeout_usec - i)); + + if (!(inb(status_addr) & EC_LPC_STATUS_BUSY_MASK)) + return 0; + + /* Increase the delay interval after a few rapid checks */ + if (i > 20) + delay = MIN(delay * 2, MAXIMUM_UDELAY); + } + return -1; /* Timeout */ +} + +static void write_memmap(uint8_t b, uint16_t addr) +{ + addr -= 0x800; + outb(addr & 0xfc, 0x802); + outb((addr >> 8) & 0x7f, 0x803); + usleep(500); + outb(b, 0x804 + (addr & 0x3)); +} + +static uint8_t read_memmap(uint16_t addr) +{ + addr -= 0x800; + outb(addr & 0xfc, 0x802); + outb((addr >> 8) & 0x7f, 0x803); + usleep(500); + return inb(0x804 + (addr & 0x3)); +} + +static void send_byte(uint8_t b, uint16_t addr) +{ + if (addr >= 0x800 && addr <= 0x9ff) + write_memmap(b, addr); + else + outb(b, addr); +} + +static uint8_t read_byte(uint16_t addr) +{ + if (addr >= 0x800 && addr <= 0x9ff) + return read_memmap(addr); + else + return inb(addr); +} + +static int ec_command_lpc(int command, int version, + const void *outdata, int outsize, + void *indata, int insize) +{ + struct ec_lpc_host_args args; + const uint8_t *d; + uint8_t *dout; + int csum; + int i; + + /* Fill in args */ + args.flags = EC_HOST_ARGS_FLAG_FROM_HOST; + args.command_version = version; + args.data_size = outsize; + + /* Initialize checksum */ + csum = command + args.flags + args.command_version + args.data_size; + + /* Write data and update checksum */ + for (i = 0, d = (uint8_t *)outdata; i < outsize; i++, d++) { + send_byte(*d, EC_LPC_ADDR_HOST_PARAM + i); + csum += *d; + } + + /* Finalize checksum and write args */ + args.checksum = (uint8_t)csum; + for (i = 0, d = (const uint8_t *)&args; i < sizeof(args); i++, d++) + send_byte(*d, EC_LPC_ADDR_HOST_ARGS + i); + + send_byte(command, EC_LPC_ADDR_HOST_CMD); + + if (wait_for_ec(EC_LPC_ADDR_HOST_CMD, 1000000)) { + fprintf(stderr, "Timeout waiting for EC response\n"); + return -EC_RES_ERROR; + } + + /* Check result */ + i = read_byte(EC_LPC_ADDR_HOST_DATA); + if (i) { + fprintf(stderr, "EC returned error result code %d\n", i); + return -i; + } + + /* Read back args */ + for (i = 0, dout = (uint8_t *)&args; i < sizeof(args); i++, dout++) + *dout = read_byte(EC_LPC_ADDR_HOST_ARGS + i); + + /* + * If EC didn't modify args flags, then somehow we sent a new-style + * command to an old EC, which means it would have read its params + * from the wrong place. + */ + if (!(args.flags & EC_HOST_ARGS_FLAG_TO_HOST)) { + fprintf(stderr, "EC protocol mismatch\n"); + return -EC_RES_INVALID_RESPONSE; + } + + if (args.data_size > insize) { + fprintf(stderr, "EC returned too much data\n"); + return -EC_RES_INVALID_RESPONSE; + } + + /* Start calculating response checksum */ + csum = command + args.flags + args.command_version + args.data_size; + + /* Read response and update checksum */ + for (i = 0, dout = (uint8_t *)indata; i < args.data_size; + i++, dout++) { + *dout = read_byte(EC_LPC_ADDR_HOST_PARAM + i); + csum += *dout; + } + + /* Verify checksum */ + if (args.checksum != (uint8_t)csum) { + fprintf(stderr, "EC response has invalid checksum\n"); + return -EC_RES_INVALID_CHECKSUM; + } + + /* Return actual amount of data received */ + return args.data_size; +} + +static int ec_command_lpc_3(int command, int version, + const void *outdata, int outsize, + void *indata, int insize) +{ + struct ec_host_request rq; + struct ec_host_response rs; + const uint8_t *d; + uint8_t *dout; + int csum = 0; + int i; + + /* Fail if output size is too big */ + if (outsize + sizeof(rq) > EC_LPC_HOST_PACKET_SIZE) + return -EC_RES_REQUEST_TRUNCATED; + + /* Fill in request packet */ + /* TODO(crosbug.com/p/23825): This should be common to all protocols */ + rq.struct_version = EC_HOST_REQUEST_VERSION; + rq.checksum = 0; + rq.command = command; + rq.command_version = version; + rq.reserved = 0; + rq.data_len = outsize; + + /* Copy data and start checksum */ + for (i = 0, d = (const uint8_t *)outdata; i < outsize; i++, d++) { + send_byte(*d, EC_LPC_ADDR_HOST_PACKET + sizeof(rq) + i); + csum += *d; + } + + /* Finish checksum */ + for (i = 0, d = (const uint8_t *)&rq; i < sizeof(rq); i++, d++) + csum += *d; + + /* Write checksum field so the entire packet sums to 0 */ + rq.checksum = (uint8_t)(-csum); + + /* Copy header */ + for (i = 0, d = (const uint8_t *)&rq; i < sizeof(rq); i++, d++) + send_byte(*d, EC_LPC_ADDR_HOST_PACKET + i); + + /* Start the command */ + send_byte(EC_COMMAND_PROTOCOL_3, EC_LPC_ADDR_HOST_CMD); + + if (wait_for_ec(EC_LPC_ADDR_HOST_CMD, 1000000)) { + fprintf(stderr, "Timeout waiting for EC response\n"); + return -EC_RES_ERROR; + } + + /* Check result */ + i = read_byte(EC_LPC_ADDR_HOST_DATA); + if (i) { + fprintf(stderr, "EC returned error result code %d\n", i); + return -i; + } + + /* Read back response header and start checksum */ + csum = 0; + for (i = 0, dout = (uint8_t *)&rs; i < sizeof(rs); i++, dout++) { + *dout = read_byte(EC_LPC_ADDR_HOST_PACKET + i); + csum += *dout; + } + + if (rs.struct_version != EC_HOST_RESPONSE_VERSION) { + fprintf(stderr, "EC response version mismatch\n"); + return -EC_RES_INVALID_RESPONSE; + } + + if (rs.reserved) { + fprintf(stderr, "EC response reserved != 0\n"); + return -EC_RES_INVALID_RESPONSE; + } + + if (rs.data_len > insize) { + fprintf(stderr, "EC returned too much data\n"); + return -EC_RES_RESPONSE_TOO_BIG; + } + + /* Read back data and update checksum */ + for (i = 0, dout = (uint8_t *)indata; i < rs.data_len; i++, dout++) { + *dout = read_byte(EC_LPC_ADDR_HOST_PACKET + sizeof(rs) + i); + csum += *dout; + } + + /* Verify checksum */ + if ((uint8_t)csum) { + fprintf(stderr, "EC response has invalid checksum\n"); + return -EC_RES_INVALID_CHECKSUM; + } + + /* Return actual amount of data received */ + return rs.data_len; +} + +static int ec_readmem_lpc(int offset, int bytes, void *dest) +{ + int i = offset; + char *s = dest; + int cnt = 0; + + if (offset >= EC_MEMMAP_SIZE - bytes) + return -1; + + if (bytes) { /* fixed length */ + for (; cnt < bytes; i++, s++, cnt++) + *s = read_byte(EC_LPC_ADDR_MEMMAP + i); + } else { /* string */ + for (; i < EC_MEMMAP_SIZE; i++, s++) { + *s = read_byte(EC_LPC_ADDR_MEMMAP + i); + cnt++; + if (!*s) + break; + } + } + + return cnt; +} + +int comm_init_lpc(void) +{ + int i; + int byte = 0xff; + + /* Request I/O privilege */ + if (iopl(3) < 0) { + perror("Error getting I/O privilege"); + return -3; + } + + /* + * Test if the I/O port has been configured for Chromium EC LPC + * interface. Chromium EC guarantees that at least one status bit will + * be 0, so if the command and data bytes are both 0xff, very likely + * that Chromium EC is not present. See crosbug.com/p/10963. + */ + byte &= read_byte(EC_LPC_ADDR_HOST_CMD); + byte &= read_byte(EC_LPC_ADDR_HOST_DATA); + if (byte == 0xff) { + fprintf(stderr, "Port 0x%x,0x%x are both 0xFF.\n", + EC_LPC_ADDR_HOST_CMD, EC_LPC_ADDR_HOST_DATA); + fprintf(stderr, + "Very likely this board doesn't have a Chromium EC.\n"); + return -4; + } + + /* + * Test if LPC command args are supported. + * + * The cheapest way to do this is by looking for the memory-mapped + * flag. This is faster than sending a new-style 'hello' command and + * seeing whether the EC sets the EC_HOST_ARGS_FLAG_FROM_HOST flag + * in args when it responds. + */ + if (read_byte(EC_LPC_ADDR_MEMMAP + EC_MEMMAP_ID) != 'E' || + read_byte(EC_LPC_ADDR_MEMMAP + EC_MEMMAP_ID + 1) != 'C') { + fprintf(stderr, "Missing Chromium EC memory map.\n"); + return -5; + } + + /* Check which command version we'll use */ + i = read_byte(EC_LPC_ADDR_MEMMAP + EC_MEMMAP_HOST_CMD_FLAGS); + + if (i & EC_HOST_CMD_FLAG_VERSION_3) { + /* Protocol version 3 */ + ec_command = ec_command_lpc_3; + ec_max_outsize = EC_LPC_HOST_PACKET_SIZE - + sizeof(struct ec_host_request); + ec_max_insize = EC_LPC_HOST_PACKET_SIZE - + sizeof(struct ec_host_response); + + } else if (i & EC_HOST_CMD_FLAG_LPC_ARGS_SUPPORTED) { + /* Protocol version 2 */ + ec_command = ec_command_lpc; + ec_max_outsize = ec_max_insize = EC_PROTO2_MAX_PARAM_SIZE; + + } else { + fprintf(stderr, "EC doesn't support protocols we need.\n"); + return -5; + } + + /* Either one supports reading mapped memory directly. */ + ec_readmem = ec_readmem_lpc; + return 0; +} |