summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDave Parker <dparker@chromium.org>2014-04-19 14:09:42 -0700
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2014-04-21 18:54:52 +0000
commitd3406b7a1088e52b88c02ac18bf3ce44074e4c88 (patch)
treebeb495b624131e24a5ed05df2ff218c1dbc6ff1f
parenteb2246892e05f1cd1b14eb131b4a15cb5d0619d4 (diff)
downloadchrome-ec-d3406b7a1088e52b88c02ac18bf3ce44074e4c88.tar.gz
Rename battery_vendor_params() to battery_override_params()
This is a clearer name for the intent of the function to override the charging parameters requested by the battery. This also disabmiguates this function with a new host command to get and set arbitrary vendor parameters in the battery. BUG=chrome-os-partner:25145 BRANCH=ToT TEST=`make buildall -j` Change-Id: I1e8762d359c0e91c5b2a539553d22c12c9850c03 Signed-off-by: Dave Parker <dparker@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/195823 Reviewed-by: Randall Spangler <rspangler@chromium.org>
-rw-r--r--board/link/board.h2
-rw-r--r--board/nyan/battery.c6
-rw-r--r--common/charge_state.c4
-rw-r--r--driver/battery/link.c6
-rw-r--r--include/battery.h2
-rw-r--r--include/config.h12
6 files changed, 16 insertions, 16 deletions
diff --git a/board/link/board.h b/board/link/board.h
index def2af9146..bf970ffcb1 100644
--- a/board/link/board.h
+++ b/board/link/board.h
@@ -14,7 +14,7 @@
#define CONFIG_BACKLIGHT_REQ_GPIO GPIO_PCH_BKLTEN
#define CONFIG_BATTERY_LINK
#define CONFIG_BATTERY_SMART
-#define CONFIG_BATTERY_VENDOR_PARAMS
+#define CONFIG_BATTERY_OVERRIDE_PARAMS
#define CONFIG_BOARD_VERSION
#define CONFIG_CHARGER
#define CONFIG_CHARGER_BQ24725
diff --git a/board/nyan/battery.c b/board/nyan/battery.c
index 6bd445fdf4..2ff7633cbc 100644
--- a/board/nyan/battery.c
+++ b/board/nyan/battery.c
@@ -98,7 +98,7 @@ static struct battery_device support_batteries[] = {
}
};
-#ifdef CONFIG_BATTERY_VENDOR_PARAMS
+#ifdef CONFIG_BATTERY_OVERRIDE_PARAMS
/*
* The following parameters are for 2S battery.
* There is no corresponding params for 3S battery.
@@ -142,7 +142,7 @@ static inline void limit_value(int *val, int limit)
*val = limit;
}
-void battery_vendor_params(struct batt_params *batt)
+void battery_override_params(struct batt_params *batt)
{
int *desired_current = &batt->desired_current;
int temp_range, volt_range;
@@ -193,7 +193,7 @@ void battery_vendor_params(struct batt_params *batt)
*desired_current < battery_info->precharge_current)
*desired_current = battery_info->precharge_current;
}
-#endif /* CONFIG_BATTERY_VENDOR_PARAMS */
+#endif /* CONFIG_BATTERY_OVERRIDE_PARAMS */
const struct battery_info *battery_get_info(void)
{
diff --git a/common/charge_state.c b/common/charge_state.c
index 7cfb6d847f..db16dbbf11 100644
--- a/common/charge_state.c
+++ b/common/charge_state.c
@@ -350,9 +350,9 @@ static int state_common(struct charge_state_context *ctx)
*ctx->memmap_batt_flags &= ~EC_BATT_FLAG_LEVEL_CRITICAL;
}
-#ifdef CONFIG_BATTERY_VENDOR_PARAMS
+#ifdef CONFIG_BATTERY_OVERRIDE_PARAMS
/* Apply battery pack vendor charging method */
- battery_vendor_params(batt);
+ battery_override_params(batt);
#endif
#ifdef CONFIG_CHARGER_CURRENT_LIMIT
diff --git a/driver/battery/link.c b/driver/battery/link.c
index f870342f9a..37a4ffb150 100644
--- a/driver/battery/link.c
+++ b/driver/battery/link.c
@@ -39,7 +39,7 @@ const struct battery_info *battery_get_info(void)
return &info;
}
-#ifdef CONFIG_BATTERY_VENDOR_PARAMS
+#ifdef CONFIG_BATTERY_OVERRIDE_PARAMS
/*
* Design capacity
@@ -93,7 +93,7 @@ static inline void limit_value(int *val, int limit)
* desired_voltage and desired_current will be passed to the charger. To use
* the smart battery's profile, simply do nothing.
*/
-void battery_vendor_params(struct batt_params *batt)
+void battery_override_params(struct batt_params *batt)
{
int *desired_current = &batt->desired_current;
int temp_range, volt_range;
@@ -137,4 +137,4 @@ void battery_vendor_params(struct batt_params *batt)
*desired_current = info.precharge_current;
}
-#endif /* CONFIG_BATTERY_VENDOR_PARAMS */
+#endif /* CONFIG_BATTERY_OVERRIDE_PARAMS */
diff --git a/include/battery.h b/include/battery.h
index 7072b522ef..8ede38641b 100644
--- a/include/battery.h
+++ b/include/battery.h
@@ -95,7 +95,7 @@ void battery_get_params(struct batt_params *batt);
*
* @param batt Battery parameters to modify
*/
-void battery_vendor_params(struct batt_params *batt);
+void battery_override_params(struct batt_params *batt);
/**
* Check for presence of battery.
diff --git a/include/config.h b/include/config.h
index 73ca90fc83..af842f957b 100644
--- a/include/config.h
+++ b/include/config.h
@@ -95,6 +95,12 @@
#undef CONFIG_BATTERY_MOCK
/*
+ * Charger should call battery_override_params() to limit/correct the voltage
+ * and current requested by the battery pack before acting on the request.
+ */
+#undef CONFIG_BATTERY_OVERRIDE_PARAMS
+
+/*
* If defined, the charger will check for battery presence before attempting
* to communicate with it. This avoids the 30 second delay when booting
* without a battery present. Do not use with CONFIG_BATTERY_PRESENT_GPIO.
@@ -120,12 +126,6 @@
*/
#undef CONFIG_BATTERY_SMART
-/*
- * Charger should call battery_vendor_params() to limit/correct the voltage and
- * current requested by the battery pack before acting on the request.
- */
-#undef CONFIG_BATTERY_VENDOR_PARAMS
-
/*****************************************************************************/
/*