diff options
| author | Brian Norris <briannorris@chromium.org> | 2022-09-02 13:40:17 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-09-02 23:21:28 +0000 |
| commit | 9bfe90b111b030419871c5035b4dc0063e2f8221 (patch) | |
| tree | 0ca7244c982a10ce197acd2486c18446350376ce | |
| parent | 1e06a1ebefb93a37086807c11206ffde9ee614f0 (diff) | |
| download | chrome-ec-9bfe90b111b030419871c5035b4dc0063e2f8221.tar.gz | |
ec: Fix DEBUG "variable" in usb_updater Makefile
DEBUG is not the way to refer to a variable in a Makefile expression;
$(DEBUG) is.
Also, make extra/rma_reset/Makefile consistent.
Drop the EOF blank line to satisfy linter.
BUG=none
TEST=build
BRANCH=none
Change-Id: Ic71be497ca83041dfdedf63c10e7c74b38c05bc8
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872546
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
| -rw-r--r-- | extra/rma_reset/Makefile | 2 | ||||
| -rw-r--r-- | extra/usb_updater/Makefile | 7 |
2 files changed, 4 insertions, 5 deletions
diff --git a/extra/rma_reset/Makefile b/extra/rma_reset/Makefile index 4a640c5b4c..4e401b8d5d 100644 --- a/extra/rma_reset/Makefile +++ b/extra/rma_reset/Makefile @@ -19,7 +19,7 @@ CFLAGS := -std=gnu99 \ -Wredundant-decls \ -Wmissing-declarations -ifeq ($(DEBUG),1) +ifneq ($(DEBUG),) CFLAGS += -g -O0 else CFLAGS += -O3 diff --git a/extra/usb_updater/Makefile b/extra/usb_updater/Makefile index 1dfbc55645..8fc1c1b07a 100644 --- a/extra/usb_updater/Makefile +++ b/extra/usb_updater/Makefile @@ -19,10 +19,10 @@ CFLAGS := -std=gnu99 \ -Wredundant-decls \ -Wmissing-declarations -ifeq (DEBUG,) -CFLAGS += -O3 -else +ifneq ($(DEBUG),) CFLAGS += -O0 +else +CFLAGS += -O3 endif # @@ -52,4 +52,3 @@ clean: parser_debug: desc_parser.c gcc -g -O0 -DTEST_PARSER desc_parser.c -o dp - |