summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSameer Nanda <snanda@chromium.org>2014-10-10 08:57:24 -0700
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2014-11-11 22:58:32 +0000
commit4cdb02fd8f8b4d310f0d5780c74a11be8d7fd142 (patch)
tree6440e95fe9e97b65b1dc8b46950fc9e5beb8d58b
parentdcfbd3930d5fa00d5f065440890686501a985823 (diff)
downloadchrome-ec-4cdb02fd8f8b4d310f0d5780c74a11be8d7fd142.tar.gz
CHERRY-PICK: temp_metrics: add "--" when invoking ectool tmp006cal
ectool has switched over to using getopt for command line options parsing. This breaks temp_metrics' invocation of "ectool tmp006cal" command since some of the coefficients are negative and therefore start with "-". getopt treats that as another command line option causing ectool to barf. BUG=chromium:422160 TEST=On a Pixel issue "sudo start temp_metrics" and check /var/log/messages to ensure that no new messages such as "init: temp_metrics main process ended, respawning" show up. BRANCH=none Change-Id: I7c5a594908c20521f0eb2cbd81cdf001eb598df7 Original-Change-Id: I42232b3027ec6339814d226f1d8ab493e3420eea Signed-off-by: Sameer Nanda <snanda@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/222845 Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/229104 Reviewed-by: Mohammed Habibulla <moch@chromium.org> Commit-Queue: Mohammed Habibulla <moch@chromium.org> Tested-by: Mohammed Habibulla <moch@chromium.org>
-rw-r--r--util/temp_metrics.conf4
1 files changed, 3 insertions, 1 deletions
diff --git a/util/temp_metrics.conf b/util/temp_metrics.conf
index 307938d019..bf10ee0907 100644
--- a/util/temp_metrics.conf
+++ b/util/temp_metrics.conf
@@ -107,7 +107,9 @@ script
CHARGER_D="3 $CHARGER_D_S0 $B0 $B1 $B2"
for i in "$USB_C" "$PCH_D" "$HINGE_C" "$CHARGER_D"; do
- ectool tmp006cal $i
+ # Add "--" otherwise ectool will barf when trying to parse negative
+ # coefficients.
+ ectool tmp006cal -- $i
done
}