summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVincent Palatin <vpalatin@chromium.org>2017-11-27 16:08:44 +0100
committerChromeOS Commit Bot <chromeos-commit-bot@chromium.org>2018-06-20 08:24:37 +0000
commit005227d8f1d3452f19c9a358b30c8ceb70a479fe (patch)
tree79b18cb59b6e1177bce3804acda1b92f819fa5c7
parent9e81762f2db03619d385b9bf91b7926e843e4a67 (diff)
downloadchrome-ec-005227d8f1d3452f19c9a358b30c8ceb70a479fe.tar.gz
twinkie: number properly the USB interfaces
In USB-PD Sink mode, the 'Commands' interface has bInterfaceNumber == 2 while the configuration defines bNumInterfaces as 2, this is likely invalid for USB. Change the Commands interface number in Sink mode. Signed-off-by: Vincent Palatin <vpalatin@chromium.org> BRANCH=twinkie BUG=none TEST=lsusb Change-Id: Id63120f11ba541a82dadb79703dcfaa5f1e8a0f4 Reviewed-on: https://chromium-review.googlesource.com/790393 Reviewed-by: Vincent Palatin <vpalatin@chromium.org> Commit-Queue: Vincent Palatin <vpalatin@chromium.org> Tested-by: Vincent Palatin <vpalatin@chromium.org>
-rw-r--r--board/twinkie/board.h8
1 files changed, 5 insertions, 3 deletions
diff --git a/board/twinkie/board.h b/board/twinkie/board.h
index 341909e09e..c6139098bf 100644
--- a/board/twinkie/board.h
+++ b/board/twinkie/board.h
@@ -135,7 +135,6 @@ enum usb_strings {
/* USB interface indexes (use define rather than enum to expand them) */
#define USB_IFACE_CONSOLE 0
#define USB_IFACE_VENDOR 1
-#define USB_IFACE_COMMAND 2
/* USB endpoint indexes (use define rather than enum to expand them) */
#define USB_EP_CONTROL 0
@@ -145,11 +144,14 @@ enum usb_strings {
#ifdef HAS_TASK_SNIFFER
#define USB_EP_SNIFFER 3
#define USB_EP_COUNT 4
-#define USB_IFACE_COUNT 3
+
+#define USB_IFACE_COMMAND 2
+#define USB_IFACE_COUNT 3
#else
#define USB_EP_COUNT 3
/* No IFACE_VENDOR for the sniffer */
-#define USB_IFACE_COUNT 2
+#define USB_IFACE_COMMAND 1
+#define USB_IFACE_COUNT 2
#endif
#endif /* __CROS_EC_BOARD_H */