summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorli feng <li1.feng@intel.com>2020-09-18 21:44:50 -0700
committerCommit Bot <commit-bot@chromium.org>2021-02-16 18:19:57 +0000
commit84b3fed036eb39d67dffd96d89d9a198a2fbf7a4 (patch)
tree01efe4e5141b84163436ba72b5720c083a4f55e7
parentca711388455097479c1e80a243a5ca91b0272805 (diff)
downloadchrome-ec-84b3fed036eb39d67dffd96d89d9a198a2fbf7a4.tar.gz
volteer: Add version number of product
Per PD Rev3.0 Spec, VDM Product VDO has a field bcdDevice, it's version number relevant to the release version of the product. BUG=b:157163664 BRANCH=none TEST=make buildall Signed-off-by: li feng <li1.feng@intel.com> Change-Id: Ie735b64c9d4a1dec2f3402b2c521c107a9769ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2420469 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2697851 Commit-Queue: Abe Levkoy <alevkoy@chromium.org> Tested-by: Abe Levkoy <alevkoy@chromium.org>
-rw-r--r--baseboard/volteer/baseboard.h2
-rw-r--r--baseboard/volteer/usb_pd_policy.c4
2 files changed, 4 insertions, 2 deletions
diff --git a/baseboard/volteer/baseboard.h b/baseboard/volteer/baseboard.h
index 85fa41c9b7..ca10f4db24 100644
--- a/baseboard/volteer/baseboard.h
+++ b/baseboard/volteer/baseboard.h
@@ -223,6 +223,8 @@
* http://google3/hardware/standards/usb/
*/
#define CONFIG_USB_PID 0x503E
+/* Device version of product. */
+#define CONFIG_USB_BCD_DEV 0x0000
/* Retimer */
#define CONFIG_USBC_RETIMER_INTEL_BB
diff --git a/baseboard/volteer/usb_pd_policy.c b/baseboard/volteer/usb_pd_policy.c
index 670654198f..3d5e59212e 100644
--- a/baseboard/volteer/usb_pd_policy.c
+++ b/baseboard/volteer/usb_pd_policy.c
@@ -103,8 +103,8 @@ static const uint32_t vdo_idh_rev30 = VDO_IDH_REV30(
USB_TYPEC_RECEPTACLE,
USB_VID_GOOGLE);
-/* TODO(b:157163664): add product version */
-static const uint32_t vdo_product = VDO_PRODUCT(CONFIG_USB_PID, 0);
+static const uint32_t vdo_product = VDO_PRODUCT(
+ CONFIG_USB_PID, CONFIG_USB_BCD_DEV);
/* TODO(b/168890624): add USB4 to capability once USB4 response implemented */
static const uint32_t vdo_ufp1 = VDO_UFP1(