diff options
| author | Diana Z <dzigterman@chromium.org> | 2021-02-08 11:03:43 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-02-23 17:56:19 +0000 |
| commit | ca370390288a5bd59dc06ad1c409e188463e7bd5 (patch) | |
| tree | a78783444618fa4d9c94414c5ee17681034df573 | |
| parent | 27da26cfd4eda142d36922dc7a966cbe006fc7bb (diff) | |
| download | chrome-ec-ca370390288a5bd59dc06ad1c409e188463e7bd5.tar.gz | |
TCPMv2: Don't reset Vconn swap counter on Accept
Currently, when a DUT is connected to another DUT they can enter into an
infinite loop of Vconn swapping. Remove the vconn swap counter re-set
on Accept, and only re-set the counter on new connections.
BRANCH=None
BUG=b:174334068,b:179334214
TEST=with two DUTs connected, connection is able to settle into a stable
state after swap attempts are exhuasted
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ib2eec57812465efbec63220142912978c6655ba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2678659
Tested-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
(cherry picked from commit 127c005ec700af12cfae91248bb3ed437c45898c)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2702997
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Tested-by: jerry2.huang <jerry2.huang@lcfc.corp-partner.google.com>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
| -rw-r--r-- | common/usbc/usb_pe_drp_sm.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/common/usbc/usb_pe_drp_sm.c b/common/usbc/usb_pe_drp_sm.c index e56ada0a48..257ef52a65 100644 --- a/common/usbc/usb_pe_drp_sm.c +++ b/common/usbc/usb_pe_drp_sm.c @@ -6235,7 +6235,6 @@ static void pe_vcs_send_swap_run(int port) * 2) The Port is not presently the VCONN Source. */ if (type == PD_CTRL_ACCEPT) { - pe[port].vconn_swap_counter = 0; if (tc_is_vconn_src(port)) { /* * Prevent receiving any SOP' and SOP'' |