diff options
| author | Abe Levkoy <alevkoy@chromium.org> | 2021-02-05 12:41:01 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-02-09 17:17:32 +0000 |
| commit | ec4570b402232b29ff080257d6246e19bb57d5db (patch) | |
| tree | 91e7d1aec5c0229400688829687ac7a697ed6115 | |
| parent | 8212140bee771058dec9f6904cd9915ea3781524 (diff) | |
| download | chrome-ec-ec4570b402232b29ff080257d6246e19bb57d5db.tar.gz | |
TCPMv2: Remove prl_reset
It is now unused in implementation code.
BUG=b:179198412,b:173725284
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: If9ce77f5958d4ee168412b22bd77cba2c4d0ec49
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2679992
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2684756
| -rw-r--r-- | common/mock/usb_prl_mock.c | 3 | ||||
| -rw-r--r-- | common/usbc/usb_prl_sm.c | 9 | ||||
| -rw-r--r-- | include/usb_prl_sm.h | 7 | ||||
| -rw-r--r-- | test/usb_prl.c | 2 | ||||
| -rw-r--r-- | test/usb_prl_old.c | 2 |
5 files changed, 2 insertions, 21 deletions
diff --git a/common/mock/usb_prl_mock.c b/common/mock/usb_prl_mock.c index 5dba2b2805..39ed2f7b2f 100644 --- a/common/mock/usb_prl_mock.c +++ b/common/mock/usb_prl_mock.c @@ -74,9 +74,6 @@ __overridable bool prl_is_busy(int port) return false; } -void prl_reset(int port) -{} - void prl_reset_soft(int port) {} diff --git a/common/usbc/usb_prl_sm.c b/common/usbc/usb_prl_sm.c index 0affa113b5..d8e4072782 100644 --- a/common/usbc/usb_prl_sm.c +++ b/common/usbc/usb_prl_sm.c @@ -692,15 +692,6 @@ void prl_reset_soft(int port) task_wake(PD_PORT_TO_TASK_ID(port)); } -void prl_reset(int port) -{ - prl_set_default_pd_revision(port); - local_state[port] = SM_INIT; - - /* Ensure we process the reset quickly */ - task_wake(PD_PORT_TO_TASK_ID(port)); -} - void prl_run(int port, int evt, int en) { switch (local_state[port]) { diff --git a/include/usb_prl_sm.h b/include/usb_prl_sm.h index 79b0b9c35c..afcaa2cfed 100644 --- a/include/usb_prl_sm.h +++ b/include/usb_prl_sm.h @@ -38,13 +38,6 @@ bool prl_is_busy(int port); void prl_set_debug_level(enum debug_level level); /** - * Resets the Protocol Layer State Machine - * - * @param port USB-C port number - */ -void prl_reset(int port); - -/** * Resets the Protocol Layer state machine but does not reset the stored PD * revisions of the partners. * diff --git a/test/usb_prl.c b/test/usb_prl.c index 42bbac4b6d..e572da4966 100644 --- a/test/usb_prl.c +++ b/test/usb_prl.c @@ -145,7 +145,7 @@ void before_test(void) mock_tcpm_reset(); mock_pe_port_reset(); - prl_reset(PORT0); + prl_reset_soft(PORT0); enable_prl(PORT0, 1); } diff --git a/test/usb_prl_old.c b/test/usb_prl_old.c index e14d915214..6d6f02c6cf 100644 --- a/test/usb_prl_old.c +++ b/test/usb_prl_old.c @@ -806,7 +806,7 @@ static int test_prl_reset(void) enable_prl(port, 1); - prl_reset(port); + prl_reset_soft(port); TEST_EQ(prl_tx_get_state(port), PRL_TX_WAIT_FOR_MESSAGE_REQUEST, "%u"); |