summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaveh Jalali <caveh@chromium.org>2023-01-18 14:38:32 -0800
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2023-01-20 09:32:30 +0000
commit04c37f5640a98872d088f58f9763546bfd7f66c5 (patch)
treeb1bc80f5fe9a9bb2c0c8c09d1bad0d4134f0c251
parent5c1ae7b6e46d7cad23aae21c2ee36ece45de8008 (diff)
downloadchrome-ec-04c37f5640a98872d088f58f9763546bfd7f66c5.tar.gz
ec_commands: Fix EC_CMD_GET_BOOT_TIME response naming
Rename the EC_CMD_GET_BOOT_TIME response struct to 'struct ec_response_get_boot_time' so it is consistent with the prevailing naming convention for host commands. The previous 'struct ap_boot_time_data' name has not propagated to any other repo (including upstream coreboot), so it is sufficient to rename it in the EC repo. BRANCH=none BUG=b:249163956 TEST='./twister -v -T zephyr/test' passes 'make buildall' passes 'make BOARD=host utils-host' passes Change-Id: Id0c02040b27b66b8e5c8bd1be08f0d59af76468c Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4179360 Reviewed-by: Boris Mittelberg <bmbm@google.com> Reviewed-by: RAJESH KUMAR <rajesh3.kumar@intel.com>
-rw-r--r--common/system_boot_time.c4
-rw-r--r--include/ec_commands.h2
-rw-r--r--util/ectool.cc2
-rw-r--r--zephyr/test/system_common/src/get_boot_time.c2
4 files changed, 5 insertions, 5 deletions
diff --git a/common/system_boot_time.c b/common/system_boot_time.c
index f807cf8047..582b80ef47 100644
--- a/common/system_boot_time.c
+++ b/common/system_boot_time.c
@@ -11,7 +11,7 @@
#ifdef CONFIG_SYSTEM_BOOT_TIME_LOGGING
/* Content of ap_boot_time will be lost on sysjump */
-static struct ap_boot_time_data ap_boot_time;
+static struct ec_response_get_boot_time ap_boot_time;
#endif
/* This function updates timestamp for ap boot time params */
@@ -46,7 +46,7 @@ void update_ap_boot_time(enum boot_time_param param)
static enum ec_status
host_command_get_boot_time(struct host_cmd_handler_args *args)
{
- struct ap_boot_time_data *boot_time = args->response;
+ struct ec_response_get_boot_time *boot_time = args->response;
if (args->response_max < sizeof(*boot_time)) {
return EC_RES_RESPONSE_TOO_BIG;
diff --git a/include/ec_commands.h b/include/ec_commands.h
index 66192d8e9f..c63c17c535 100644
--- a/include/ec_commands.h
+++ b/include/ec_commands.h
@@ -7850,7 +7850,7 @@ enum boot_time_param {
RESET_CNT,
};
-struct ap_boot_time_data {
+struct ec_response_get_boot_time {
uint64_t timestamp[RESET_CNT];
uint16_t cnt;
} __ec_align4;
diff --git a/util/ectool.cc b/util/ectool.cc
index 186d0a11e5..4c066efc72 100644
--- a/util/ectool.cc
+++ b/util/ectool.cc
@@ -8399,7 +8399,7 @@ int cmd_board_version(int argc, char *argv[])
int cmd_boottime(int argc, char *argv[])
{
- struct ap_boot_time_data response;
+ struct ec_response_get_boot_time response;
int rv;
rv = ec_command(EC_CMD_GET_BOOT_TIME, 0, NULL, 0, &response,
diff --git a/zephyr/test/system_common/src/get_boot_time.c b/zephyr/test/system_common/src/get_boot_time.c
index bcf665dc65..7cf7c6fffd 100644
--- a/zephyr/test/system_common/src/get_boot_time.c
+++ b/zephyr/test/system_common/src/get_boot_time.c
@@ -18,7 +18,7 @@ ZTEST_SUITE(host_cmd_get_boot_time, NULL, NULL, NULL, NULL, NULL);
ZTEST(host_cmd_get_boot_time, test_get_boot_time)
{
int ret;
- struct ap_boot_time_data r;
+ struct ec_response_get_boot_time r;
struct host_cmd_handler_args args =
BUILD_HOST_COMMAND_RESPONSE(EC_CMD_GET_BOOT_TIME, 0, r);