diff options
| author | Caveh Jalali <caveh@chromium.org> | 2023-01-12 01:39:04 -0800 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-01-18 07:18:16 +0000 |
| commit | 2f780954e0f4068fd23e89e20c539736ca4dd2c4 (patch) | |
| tree | 9db2e9f28523bbd159cc4d96d2667f4cd1e3bb93 | |
| parent | 88f7615a6cc0c0e71950e4e54d6b28c6a4a0f696 (diff) | |
| download | chrome-ec-2f780954e0f4068fd23e89e20c539736ca4dd2c4.tar.gz | |
zephyr/test: keyboard_scan: Fix MKBP_SIMULATE_KEY test
The EC_CMD_MKBP_SIMULATE_KEY host command does not return data. Remove
code that sets up a 'struct ec_response_keyboard_factory_test' as the
return parameter.
BRANCH=none
BUG=b:258110734
TEST='./twister -v -T zephyr/test' passes
Change-Id: Iac1a95453e612b384e22b0cf99812a134b18e378
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4171497
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Boris Mittelberg <bmbm@google.com>
| -rw-r--r-- | zephyr/test/drivers/keyboard_scan/src/keyboard_scan.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/zephyr/test/drivers/keyboard_scan/src/keyboard_scan.c b/zephyr/test/drivers/keyboard_scan/src/keyboard_scan.c index 91b69562b1..ddd5b2d66f 100644 --- a/zephyr/test/drivers/keyboard_scan/src/keyboard_scan.c +++ b/zephyr/test/drivers/keyboard_scan/src/keyboard_scan.c @@ -239,10 +239,9 @@ ZTEST(keyboard_scan, host_command_simulate_key__locked) zassert_true(system_is_locked(), "Expecting locked system."); - struct ec_response_keyboard_factory_test response; struct ec_params_mkbp_simulate_key params; - struct host_cmd_handler_args args = BUILD_HOST_COMMAND( - EC_CMD_MKBP_SIMULATE_KEY, 0, response, params); + struct host_cmd_handler_args args = + BUILD_HOST_COMMAND_PARAMS(EC_CMD_MKBP_SIMULATE_KEY, 0, params); ret = host_command_process(&args); zassert_equal(EC_RES_ACCESS_DENIED, ret, "Command returned %u", ret); @@ -255,13 +254,12 @@ ZTEST(keyboard_scan, host_command_simulate_key__bad_params) system_is_locked_fake.return_val = 0; zassert_false(system_is_locked(), "Expecting unlocked system."); - struct ec_response_keyboard_factory_test response; struct ec_params_mkbp_simulate_key params = { .col = KEYBOARD_COLS_MAX, .row = KEYBOARD_ROWS, }; - struct host_cmd_handler_args args = BUILD_HOST_COMMAND( - EC_CMD_MKBP_SIMULATE_KEY, 0, response, params); + struct host_cmd_handler_args args = + BUILD_HOST_COMMAND_PARAMS(EC_CMD_MKBP_SIMULATE_KEY, 0, params); ret = host_command_process(&args); zassert_equal(EC_RES_INVALID_PARAM, ret, "Command returned %u", ret); |