diff options
author | lennon chen <lennon_chen@wistron.corp-partner.google.com> | 2020-08-29 00:29:08 +0800 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2020-09-12 03:22:16 +0000 |
commit | 100d6ae9ec1f637f61b414a14c4c9299ce341e09 (patch) | |
tree | bac1b401966d3b0b208b2019ebb179d2c196e9b7 | |
parent | 7269813d6e3d0e383abc915c1971deb2cccd45db (diff) | |
download | chrome-ec-100d6ae9ec1f637f61b414a14c4c9299ce341e09.tar.gz |
Eldrid: Implement LED function
Modify LED behavior to meet LED specification
1.Power led:
System is S0: White
System is suspend/S0ix: blinking white (1 sec on/off)
System is S5: Off
2.charger led:
Charging: amber on
Full charged: white on
Discharging: led Off
Blinking white (0.4 sec on/off): battery error
Blinking white (1 sec on/off): Fuel < 10%, blinking on right side port
Blinking amber (1 sec on/off): Force idle for factory
BUG=b:165875385
BRANCH=none
TEST=Check behavior to meet LED specification
TEST=make -j BOARD=eldrid
TEST=make buildall
Change-Id: I693137e5512e4c8a2f8cac39389bd23e0ca2f2c7
Signed-off-by: lennon chen <lennon_chen@wistron.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2385023
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Tested-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Commit-Queue: caveh jalali <caveh@chromium.org>
-rw-r--r-- | board/eldrid/board.c | 18 | ||||
-rw-r--r-- | board/eldrid/board.h | 10 | ||||
-rw-r--r-- | board/eldrid/gpio.inc | 5 | ||||
-rw-r--r-- | board/eldrid/led.c | 176 |
4 files changed, 108 insertions, 101 deletions
diff --git a/board/eldrid/board.c b/board/eldrid/board.c index da11fdb076..8ff38077a5 100644 --- a/board/eldrid/board.c +++ b/board/eldrid/board.c @@ -74,9 +74,8 @@ union volteer_cbi_fw_config fw_config_defaults = { static void board_init(void) { - /* Illuminate motherboard and daughter board LEDs equally to start. */ pwm_enable(PWM_CH_LED4_SIDESEL, 1); - pwm_set_duty(PWM_CH_LED4_SIDESEL, 50); + pwm_set_duty(PWM_CH_LED4_SIDESEL, 100); } DECLARE_HOOK(HOOK_INIT, board_init, HOOK_PRIO_DEFAULT); @@ -213,21 +212,6 @@ const unsigned int i2c_ports_used = ARRAY_SIZE(i2c_ports); /******************************************************************************/ /* PWM configuration */ const struct pwm_t pwm_channels[] = { - [PWM_CH_LED1_BLUE] = { - .channel = 2, - .flags = PWM_CONFIG_ACTIVE_LOW | PWM_CONFIG_DSLEEP, - .freq = 4800, - }, - [PWM_CH_LED2_GREEN] = { - .channel = 0, - .flags = PWM_CONFIG_ACTIVE_LOW | PWM_CONFIG_DSLEEP, - .freq = 4800, - }, - [PWM_CH_LED3_RED] = { - .channel = 1, - .flags = PWM_CONFIG_ACTIVE_LOW | PWM_CONFIG_DSLEEP, - .freq = 4800, - }, [PWM_CH_LED4_SIDESEL] = { .channel = 7, .flags = PWM_CONFIG_ACTIVE_LOW | PWM_CONFIG_DSLEEP, diff --git a/board/eldrid/board.h b/board/eldrid/board.h index af577086a0..8e59d5e0c6 100644 --- a/board/eldrid/board.h +++ b/board/eldrid/board.h @@ -33,9 +33,8 @@ #define CONFIG_POWER_PP5000_CONTROL /* LED defines */ -#define CONFIG_LED_PWM -/* Although there are 2 LEDs, they are both controlled by the same lines. */ -#define CONFIG_LED_PWM_COUNT 1 +#define CONFIG_LED_POWER_LED +#define CONFIG_LED_ONOFF_STATES /* Keyboard features */ @@ -179,10 +178,7 @@ enum battery_type { }; enum pwm_channel { - PWM_CH_LED1_BLUE = 0, - PWM_CH_LED2_GREEN, - PWM_CH_LED3_RED, - PWM_CH_LED4_SIDESEL, + PWM_CH_LED4_SIDESEL = 0, PWM_CH_FAN, PWM_CH_KBLIGHT, PWM_CH_COUNT diff --git a/board/eldrid/gpio.inc b/board/eldrid/gpio.inc index 4435934c74..84dc5de15f 100644 --- a/board/eldrid/gpio.inc +++ b/board/eldrid/gpio.inc @@ -96,6 +96,10 @@ UNIMPLEMENTED(USB_C1_LS_EN) /* Misc Signals */ GPIO(EC_H1_PACKET_MODE, PIN(7, 5), GPIO_OUT_LOW) /* H1 Packet Mode */ +GPIO(LED_1_L, PIN(C, 4), GPIO_OUT_HIGH) /* Battery LED: Amber */ +GPIO(LED_2_L, PIN(C, 3), GPIO_OUT_HIGH) /* Battery LED: White */ +GPIO(POWER_LED_GATE, PIN(C, 2), GPIO_OUT_LOW) /* Power LED: White */ + /* * Despite their names, M2_SSD_PLN and M2_SSD_PLA are active-low, and M2_SSD_PLN * is open-drain. @@ -148,7 +152,6 @@ ALTERNATE(PIN_MASK(B, BIT(3) | BIT(2)), 0, MODULE_I2C, 0) * board, to be controlled by LED_{1,2,3}_L. PWM allows driving both modules at * the same time. */ ALTERNATE(PIN_MASK(6, BIT(0)), 0, MODULE_PWM, 0) /* LED_SIDESEL_4_L */ -ALTERNATE(PIN_MASK(C, BIT(2) | BIT(3) | BIT(4)), 0, MODULE_PWM, 0) /* LED_{3,2,1}_L */ /* Fan signals */ GPIO(EN_PP5000_FAN, PIN(6, 1), GPIO_OUT_LOW) diff --git a/board/eldrid/led.c b/board/eldrid/led.c index 4486bcb912..eecbf9b345 100644 --- a/board/eldrid/led.c +++ b/board/eldrid/led.c @@ -1,104 +1,128 @@ /* Copyright 2020 The Chromium OS Authors. All rights reserved. * Use of this source code is governed by a BSD-style license that can be * found in the LICENSE file. - * - * Power and battery LED control for Volteer */ #include "charge_manager.h" -#include "common.h" #include "ec_commands.h" -#include "hooks.h" +#include "gpio.h" #include "led_common.h" -#include "led_pwm.h" +#include "led_onoff_states.h" #include "pwm.h" -const enum ec_led_id supported_led_ids[] = { - EC_LED_ID_POWER_LED, -}; -const int supported_led_ids_count = ARRAY_SIZE(supported_led_ids); +#define BAT_LED_ON_LVL 0 +#define BAT_LED_OFF_LVL 1 -struct pwm_led led_color_map[] = { - /* Red, Green, Blue */ - [EC_LED_COLOR_RED] = { 100, 0, 0 }, - [EC_LED_COLOR_GREEN] = { 0, 100, 0 }, - [EC_LED_COLOR_BLUE] = { 0, 0, 100 }, - /* The green LED seems to be brighter than the others, so turn down - * green from its natural level for these secondary colors. - */ - [EC_LED_COLOR_YELLOW] = { 100, 70, 0 }, - [EC_LED_COLOR_WHITE] = { 100, 70, 100 }, - [EC_LED_COLOR_AMBER] = { 100, 20, 0 }, -}; +#define PWR_LED_ON_LVL 1 +#define PWR_LED_OFF_LVL 0 -struct pwm_led pwm_leds[] = { - /* 2 RGB diffusers controlled by 1 set of 3 channels. */ - [PWM_LED0] = { - .ch0 = PWM_CH_LED3_RED, - .ch1 = PWM_CH_LED2_GREEN, - .ch2 = PWM_CH_LED1_BLUE, - .enable = &pwm_enable, - .set_duty = &pwm_set_duty, +/* LED_SIDESEL_4_L=1, MB BAT LED open + * LED_SIDESEL_4_L=0, DB BAT LED open + */ +#define LED_SISESEL_MB_PORT 0 +#define LED_SISESEL_DB_PORT 1 + +const int led_charge_lvl_1 = 5; + +const int led_charge_lvl_2 = 95; + +struct led_descriptor led_bat_state_table[LED_NUM_STATES][LED_NUM_PHASES] = { + [STATE_CHARGING_LVL_1] = {{EC_LED_COLOR_AMBER, LED_INDEFINITE} }, + [STATE_CHARGING_LVL_2] = {{EC_LED_COLOR_AMBER, LED_INDEFINITE} }, + [STATE_CHARGING_FULL_CHARGE] = {{EC_LED_COLOR_WHITE, LED_INDEFINITE} }, + [STATE_DISCHARGE_S0] = {{LED_OFF, LED_INDEFINITE} }, + [STATE_DISCHARGE_S3] = {{LED_OFF, LED_INDEFINITE} }, + [STATE_DISCHARGE_S5] = {{LED_OFF, LED_INDEFINITE} }, + [STATE_BATTERY_ERROR] = { + {EC_LED_COLOR_WHITE, 0.4 * LED_ONE_SEC}, + {LED_OFF, 0.4 * LED_ONE_SEC} + }, + [STATE_FACTORY_TEST] = { + {EC_LED_COLOR_WHITE, 1 * LED_ONE_SEC}, + {LED_OFF, 1 * LED_ONE_SEC} }, }; -void led_get_brightness_range(enum ec_led_id led_id, uint8_t *brightness_range) -{ - brightness_range[EC_LED_COLOR_RED] = 255; - brightness_range[EC_LED_COLOR_GREEN] = 255; - brightness_range[EC_LED_COLOR_BLUE] = 255; -} +const struct led_descriptor + led_pwr_state_table[PWR_LED_NUM_STATES][LED_NUM_PHASES] = { + [PWR_LED_STATE_ON] = {{EC_LED_COLOR_WHITE, LED_INDEFINITE} }, + [PWR_LED_STATE_SUSPEND_AC] = {{EC_LED_COLOR_WHITE, 1 * LED_ONE_SEC}, + {LED_OFF, 1 * LED_ONE_SEC} }, + [PWR_LED_STATE_SUSPEND_NO_AC] = {{EC_LED_COLOR_WHITE, 1 * LED_ONE_SEC}, + {LED_OFF, 1 * LED_ONE_SEC} }, + [PWR_LED_STATE_OFF] = { + {LED_OFF, LED_INDEFINITE} }, +}; -int led_set_brightness(enum ec_led_id led_id, const uint8_t *brightness) -{ - enum pwm_led_id pwm_id; - /* Convert ec_led_id to pwm_led_id. */ - if (led_id == EC_LED_ID_POWER_LED) - pwm_id = PWM_LED0; - else - return EC_ERROR_UNKNOWN; - - if (brightness[EC_LED_COLOR_RED]) - set_pwm_led_color(pwm_id, EC_LED_COLOR_RED); - else if (brightness[EC_LED_COLOR_GREEN]) - set_pwm_led_color(pwm_id, EC_LED_COLOR_GREEN); - else if (brightness[EC_LED_COLOR_BLUE]) - set_pwm_led_color(pwm_id, EC_LED_COLOR_BLUE); - else if (brightness[EC_LED_COLOR_YELLOW]) - set_pwm_led_color(pwm_id, EC_LED_COLOR_YELLOW); - else if (brightness[EC_LED_COLOR_WHITE]) - set_pwm_led_color(pwm_id, EC_LED_COLOR_WHITE); - else if (brightness[EC_LED_COLOR_AMBER]) - set_pwm_led_color(pwm_id, EC_LED_COLOR_AMBER); - else - /* Otherwise, the "color" is "off". */ - set_pwm_led_color(pwm_id, -1); +const enum ec_led_id supported_led_ids[] = { + EC_LED_ID_BATTERY_LED, + EC_LED_ID_POWER_LED, +}; - return EC_SUCCESS; -} +const int supported_led_ids_count = ARRAY_SIZE(supported_led_ids); -/* Illuminates the LED on the side of the active charging port. If not charging, - * illuminates both LEDs. - */ -static void led_set_charge_port_tick(void) +void led_set_color_battery(enum ec_led_colors color) { int port; - int side_select_duty; port = charge_manager_get_active_charge_port(); - switch (port) { - case 0: - side_select_duty = 100; + + if (led_auto_control_is_enabled(EC_LED_ID_BATTERY_LED)) + pwm_set_duty(PWM_CH_LED4_SIDESEL, + (port == LED_SISESEL_MB_PORT ? 0 : 100)); + + switch (color) { + case EC_LED_COLOR_AMBER: + gpio_set_level(GPIO_LED_1_L, BAT_LED_ON_LVL); + gpio_set_level(GPIO_LED_2_L, BAT_LED_OFF_LVL); + break; + case EC_LED_COLOR_WHITE: + gpio_set_level(GPIO_LED_1_L, BAT_LED_OFF_LVL); + gpio_set_level(GPIO_LED_2_L, BAT_LED_ON_LVL); break; - case 1: - side_select_duty = 0; + default: /* LED_OFF and other unsupported colors */ + gpio_set_level(GPIO_LED_1_L, BAT_LED_OFF_LVL); + gpio_set_level(GPIO_LED_2_L, BAT_LED_OFF_LVL); break; - default: - side_select_duty = 50; } +} + +void led_set_color_power(enum ec_led_colors color) +{ + if (color == EC_LED_COLOR_WHITE) + gpio_set_level(GPIO_POWER_LED_GATE, PWR_LED_ON_LVL); + else + /* LED_OFF and unsupported colors */ + gpio_set_level(GPIO_POWER_LED_GATE, PWR_LED_OFF_LVL); +} + +void led_get_brightness_range(enum ec_led_id led_id, uint8_t *brightness_range) +{ + if (led_id == EC_LED_ID_BATTERY_LED) { + brightness_range[EC_LED_COLOR_AMBER] = 1; + brightness_range[EC_LED_COLOR_WHITE] = 1; + } else if (led_id == EC_LED_ID_POWER_LED) { + brightness_range[EC_LED_COLOR_WHITE] = 1; + } +} - if (led_auto_control_is_enabled(EC_LED_ID_POWER_LED)) - pwm_set_duty(PWM_CH_LED4_SIDESEL, side_select_duty); +int led_set_brightness(enum ec_led_id led_id, const uint8_t *brightness) +{ + if (led_id == EC_LED_ID_BATTERY_LED) { + if (brightness[EC_LED_COLOR_AMBER] != 0) + led_set_color_battery(EC_LED_COLOR_AMBER); + else if (brightness[EC_LED_COLOR_WHITE] != 0) + led_set_color_battery(EC_LED_COLOR_WHITE); + else + led_set_color_battery(LED_OFF); + } else if (led_id == EC_LED_ID_POWER_LED) { + if (brightness[EC_LED_COLOR_WHITE] != 0) + led_set_color_power(EC_LED_COLOR_WHITE); + else + led_set_color_power(LED_OFF); + } + + return EC_SUCCESS; } -DECLARE_HOOK(HOOK_TICK, led_set_charge_port_tick, HOOK_PRIO_DEFAULT); + |