diff options
| author | Vic Yang <victoryang@chromium.org> | 2012-03-02 10:02:06 -0800 |
|---|---|---|
| committer | Vic Yang <victoryang@chromium.org> | 2012-03-02 10:09:56 -0800 |
| commit | 26ab6057d2e6f43638e0dfaa0370276f7a82794a (patch) | |
| tree | 79c6d76b04e9e78b23bd7725de6e8656bf08ba4a | |
| parent | 1db93690d9b3fed1690f6645408384451c42519b (diff) | |
| download | chrome-ec-26ab6057d2e6f43638e0dfaa0370276f7a82794a.tar.gz | |
Fix a bug causing ectool to return error return code.
'ectool temps 0' always have non-zero return code.
Signed-off-by: Vic Yang <victoryang@chromium.org>
BUG=chrome-os-partner:8294
TEST="ectool temps 0 && echo 'test'" gives 'test' on screen.
Change-Id: I3a4eff513638c25ec68e24968ce9d1022b4c1281
| -rw-r--r-- | util/ectool.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/util/ectool.c b/util/ectool.c index dfa764c5fa..b6a774f851 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -530,11 +530,16 @@ int cmd_temperature(int argc, char *argv[]) printf("Reading temperature..."); rv = read_mapped_mem8(EC_LPC_MEMMAP_TEMP_SENSOR + id); - if (rv == 0xff) + if (rv == 0xff) { + printf("Sensor not present\n"); + return -1; + } else if (rv == 0xfe) { printf("Error\n"); - else + return -1; + } else { printf("%d\n", rv + EC_LPC_TEMP_SENSOR_OFFSET); - return rv; + return 0; + } } |